Add CSV spec descriptors#89
Add CSV spec descriptors#89openshift-merge-bot[bot] merged 1 commit intoopenstack-lightspeed:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lpiwowar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
748c271 to
021316c
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
021316c to
2fd8720
Compare
umago
left a comment
There was a problem hiding this comment.
Thanks! I think it looks good, I left a suggestion for the llmCredentials configuration description.
| specDescriptors: | ||
| - description: |- | ||
| Secret name containing API token for the LLMEndpoint. The key for the field | ||
| in the secret that holds the token should be "apitoken". |
There was a problem hiding this comment.
Nit (non-blocking): The second part of the sentence sounds a bit off, may I suggest:
The secret must include a field named "apitoken" containing token value
There was a problem hiding this comment.
or
The secret must contain a field named "apitoken" which holds the token value
(A bit more similar to the original)
Add operator-sdk CSV annotations to OpenStackLightspeed spec fields to generate proper spec descriptors in the ClusterServiceVersion manifests. This ensures the operator passes scorecard tests [1] (olm-spec-descriptors test). [1] https://sdk.operatorframework.io/docs/testing-operators/scorecard/
2fd8720 to
bd0f5ca
Compare
|
/lgtm |
becbafb
into
openstack-lightspeed:main
Add operator-sdk CSV annotations to OpenStackLightspeed spec fields to generate proper spec descriptors in the ClusterServiceVersion manifests. This ensures the operator passes scorecard tests [1] (olm-spec-descriptors-test test).
[1] https://sdk.operatorframework.io/docs/testing-operators/scorecard/
Before the fix
Note
It is recommended to run these tests as part of the community-operators pipeline. If we do not fix this then these tests will fail.