Skip to content

Add CSV spec descriptors#89

Merged
openshift-merge-bot[bot] merged 1 commit intoopenstack-lightspeed:mainfrom
lpiwowar:lpiwowar/scorecard
Feb 19, 2026
Merged

Add CSV spec descriptors#89
openshift-merge-bot[bot] merged 1 commit intoopenstack-lightspeed:mainfrom
lpiwowar:lpiwowar/scorecard

Conversation

@lpiwowar
Copy link
Contributor

Add operator-sdk CSV annotations to OpenStackLightspeed spec fields to generate proper spec descriptors in the ClusterServiceVersion manifests. This ensures the operator passes scorecard tests [1] (olm-spec-descriptors-test test).

[1] https://sdk.operatorframework.io/docs/testing-operators/scorecard/

Before the fix

$ operator-sdk scorecard ./bundle
...
--------------------------------------------------------------------------------
Image:      quay.io/operator-framework/scorecard-test:v1.38.0
Entrypoint: [scorecard-test olm-spec-descriptors]
Labels:
	"suite":"olm"
	"test":"olm-spec-descriptors-test"
Results:
	Name: olm-spec-descriptors
	State: fail

	Suggestions:
		Add a spec descriptor for llmCredentials
		Add a spec descriptor for llmEndpoint
		Add a spec descriptor for modelName
		Add a spec descriptor for tlsCACertBundle
	Errors:
		llmCredentials does not have a spec descriptor
		llmEndpoint does not have a spec descriptor
		modelName does not have a spec descriptor
		tlsCACertBundle does not have a spec descriptor
	Log:
		Loaded ClusterServiceVersion: openstack-lightspeed-operator.v0.0.1
		Loaded 1 Custom Resources from alm-examples
...

Note

It is recommended to run these tests as part of the community-operators pipeline. If we do not fix this then these tests will fail.

@openshift-ci openshift-ci bot requested review from Akrog and umago February 19, 2026 12:12
@openshift-ci
Copy link

openshift-ci bot commented Feb 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lpiwowar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/openstack-lightspeed/operator for 89,021316cd0033085cda073e7dcd5831689e3f1422

Copy link
Contributor

@umago umago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think it looks good, I left a suggestion for the llmCredentials configuration description.

specDescriptors:
- description: |-
Secret name containing API token for the LLMEndpoint. The key for the field
in the secret that holds the token should be "apitoken".
Copy link
Contributor

@umago umago Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit (non-blocking): The second part of the sentence sounds a bit off, may I suggest:

The secret must include a field named "apitoken" containing token value

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or

The secret must contain a field named "apitoken" which holds the token value

(A bit more similar to the original)

Add operator-sdk CSV annotations to OpenStackLightspeed spec fields to
generate proper spec descriptors in the ClusterServiceVersion manifests.
This ensures the operator passes scorecard tests [1] (olm-spec-descriptors
test).

[1] https://sdk.operatorframework.io/docs/testing-operators/scorecard/
@umago
Copy link
Contributor

umago commented Feb 19, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 19, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit becbafb into openstack-lightspeed:main Feb 19, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants