Remove TEST_JUJU3 env var from setup.py#697
Merged
Merged
Conversation
This means that the restriction of juju<3 is removed.
Member
|
The CI is failing on a race condition when pulling the images This change should address this diff --git a/.github/workflows/tox.yaml b/.github/workflows/tox.yaml
index 2ba834e..d3e96f5 100644
--- a/.github/workflows/tox.yaml
+++ b/.github/workflows/tox.yaml
@@ -106,8 +106,8 @@ jobs:
sudo iptables -F FORWARD
sudo iptables -P FORWARD ACCEPT
# pull images
- lxc image copy --alias juju/focal/amd64 --copy-aliases ubuntu-daily:focal local:
- lxc image copy --alias juju/jammy/amd64 --copy-aliases ubuntu-daily:jammy local:
+ lxc image copy --alias juju/ubuntu@20.04/amd64 --alias juju/focal/amd64 --copy-aliases ubuntu-daily:focal local:
+ lxc image copy --alias juju/ubuntu@22.04/amd64 --alias juju/jammy/amd64 --copy-aliases ubuntu-daily:jammy local:
lxc image list
juju bootstrap localhost
- name: Functional test |
freyes
approved these changes
May 15, 2026
freyes
left a comment
Member
There was a problem hiding this comment.
Downstream can manage this through constraints or requirements pinning.
I agree we don't need this here anymore.
The CI job failed on 5 attempts, all of them were jujud (controller) dropping the client(s) and preventing clients to reconnect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means that the restriction of juju<3 is removed.