Fix e2e: Use a 4.20 jobs instead of 4.14 in e2etest#3266
Fix e2e: Use a 4.20 jobs instead of 4.14 in e2etest#3266openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
Skipping CI for Draft Pull Request. |
|
/test all |
WalkthroughUpdated OpenShift release references from 4.14 to 4.20 (and base from 4.13 to 4.19) across e2e configuration, setup scripts, and test constants; replaced three 4.14 job entries with three 4.20 job entries in CI config. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 8✅ Passed checks (8 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
|
/test e2e |
|
/test all |
|
/test e2e |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@config/e2e-openshift.yaml`:
- Around line 4-8: The listed 4.20 job keys (under the "4.20" map) reference job
names periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial-2of2,
periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial-1of2 and
periodic-ci-openshift-release-master-nightly-4.20-e2e-gcp-ovn-csi which may not
match the real Prow job names; verify in the OpenShift CI Prow config that these
exact job names exist and are active, and if they do not, replace them with the
correct names (e.g., the actual pattern like
periodic-ci-openshift-release-master-ci-4.20-e2e-*-ovn) or remove them from the
"4.20" map so the mapping only references valid, currently-running Prow jobs.
In `@test/e2e/util/e2erequest.go`:
- Around line 16-17: Tests use Release and BaseRelease constants ("Release" and
"BaseRelease" in e2erequest.go) that don't match any view returned by
ViewsMatchingReleases(); update either the YAML or the constants so the test
queries match an existing view: add a new view entry in e2e-views.yaml with
sample_release="4.20" and base_release="4.19" (e.g., name "4.20-main"), or
change the constants in e2erequest.go to BaseRelease="4.13" and Release="4.14"
to align with the existing "4.14-main" view so ViewsMatchingReleases() returns
data.
🧹 Nitpick comments (1)
scripts/e2e.sh (1)
57-62: Import time may increase significantly with release 4.20.The comment states older releases are used because they "have very few job runs and thus import quickly, ~5 minutes." Release 4.20 is newer and likely has more job runs, which could substantially increase import time and affect local developer experience.
Consider updating the comment to reflect the expected import time for 4.20, or verify the actual import duration.
| "4.20": | ||
| jobs: | ||
| periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-sdn-serial: true | ||
| periodic-ci-openshift-release-master-ci-4.14-e2e-azure-ovn-upgrade: true | ||
| periodic-ci-openshift-release-master-nightly-4.14-e2e-gcp-sdn: true | ||
| periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial-2of2: true | ||
| periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial-1of2: true | ||
| periodic-ci-openshift-release-master-nightly-4.20-e2e-gcp-ovn-csi: true |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
OpenShift CI prow jobs 4.20 e2e-aws-ovn e2e-gcp-ovn
💡 Result:
OpenShift CI (Prow) jobs for OCP 4.20 OVN E2E
- AWS OVN (periodic/blocking on 4.20 nightlies):
periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn[1] - GCP OVN (periodic):
periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn[2]
PR (pull) job examples (release-4.20 branch):
- GCP OVN:
pull-ci-openshift-origin-release-4.20-e2e-gcp-ovn[3] - AWS OVN variant found (FIPS):
pull-ci-openshift-origin-release-4.20-e2e-aws-ovn-fips[4]
References:
[1] (amd64.ocp.releases.ci.openshift.org)
[2] (prow.ci.openshift.org)
[3] (deck-ci.apps.ci.l2s4.p1.openshiftapps.com)
[4] (deck-ci.apps.ci.l2s4.p1.openshiftapps.com)
Citations:
- 1: https://amd64.ocp.releases.ci.openshift.org/releasetag/4.20.0-0.nightly-2026-01-18-030125?utm_source=openai
- 2: https://prow.ci.openshift.org/view/gs/test-platform-results/logs/periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn/1923562652026540032?utm_source=openai
- 3: https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gs/test-platform-results/pr-logs/pull/30473/pull-ci-openshift-origin-release-4.20-e2e-gcp-ovn/1988253391788183552?utm_source=openai
- 4: https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gs/test-platform-results/pr-logs/pull/30295/pull-ci-openshift-origin-release-4.20-e2e-aws-ovn-fips/1970706184457424896?utm_source=openai
🏁 Script executed:
# Search the codebase for references to these job names or similar patterns
rg "periodic-ci-openshift-release-master-nightly-4\.(20|14)" --type yaml -A 2 -B 2Repository: openshift/sippy
Length of output: 458
🏁 Script executed:
# Check if there's a job configuration or registry in the codebase
fd -e yaml -e json | xargs grep -l "periodic-ci-openshift-release.*4\.(14|20)" 2>/dev/null | head -20Repository: openshift/sippy
Length of output: 41
Verify job names match actual OpenShift CI Prow configuration.
The job names reference master-nightly variants with -serial-2of2, -serial-1of2, and -csi suffixes, but OpenShift CI 4.20 OVN jobs appear to follow the pattern periodic-ci-openshift-release-master-ci-4.20-e2e-*-ovn without these suffixes. Confirm these specific job name variants (periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial-2of2, periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial-1of2, and periodic-ci-openshift-release-master-nightly-4.20-e2e-gcp-ovn-csi) exist in Prow configuration and are actively running.
🤖 Prompt for AI Agents
In `@config/e2e-openshift.yaml` around lines 4 - 8, The listed 4.20 job keys
(under the "4.20" map) reference job names
periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial-2of2,
periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial-1of2 and
periodic-ci-openshift-release-master-nightly-4.20-e2e-gcp-ovn-csi which may not
match the real Prow job names; verify in the OpenShift CI Prow config that these
exact job names exist and are active, and if they do not, replace them with the
correct names (e.g., the actual pattern like
periodic-ci-openshift-release-master-ci-4.20-e2e-*-ovn) or remove them from the
"4.20" map so the mapping only references valid, currently-running Prow jobs.
4dbe6e9 to
ea61c60
Compare
|
/test e2e |
1 similar comment
|
/test e2e |
ea61c60 to
f000603
Compare
|
/test e2e |
|
@ngopalak-redhat: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neisw, ngopalak-redhat The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Use 4.20 jobs instead of 4.14 to fix the e2e tests. The old jobs are not available and hence the test failed.
Summary by CodeRabbit
Chores
Tests