Skip to content

Fix e2e: Use a 4.20 jobs instead of 4.14 in e2etest#3266

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
ngopalak-redhat:e2e-broken
Feb 13, 2026
Merged

Fix e2e: Use a 4.20 jobs instead of 4.14 in e2etest#3266
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
ngopalak-redhat:e2e-broken

Conversation

@ngopalak-redhat
Copy link
Copy Markdown
Contributor

@ngopalak-redhat ngopalak-redhat commented Feb 13, 2026

Use 4.20 jobs instead of 4.14 to fix the e2e tests. The old jobs are not available and hence the test failed.

Summary by CodeRabbit

  • Chores

    • Updated scheduled release jobs and CI targets from OpenShift 4.14 to 4.20, replacing legacy job entries with their 4.20 equivalents.
    • Updated e2e configuration and view defaults to reference OpenShift 4.20/4.19 as the base/sample release.
  • Tests

    • Updated end-to-end setup and seed-data invocation to use OpenShift 4.20.

@openshift-ci-robot
Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 13, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ngopalak-redhat
Copy link
Copy Markdown
Contributor Author

/test all

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Feb 13, 2026

Walkthrough

Updated OpenShift release references from 4.14 to 4.20 (and base from 4.13 to 4.19) across e2e configuration, setup scripts, and test constants; replaced three 4.14 job entries with three 4.20 job entries in CI config.

Changes

Cohort / File(s) Summary
E2E CI config
config/e2e-openshift.yaml
Top-level release key changed 4.144.20; removed three 4.14 job entries and added three corresponding 4.20 job entries (AWS/GCP/Azure job name changes).
E2E views config
config/e2e-views.yaml
Updated component_readiness base/sample release fields and name: base_release 4.134.19, base/sample release references updated to 4.20.
E2E setup scripts
e2e-scripts/sippy-e2e-sippy-e2e-setup-commands.sh, scripts/e2e.sh
Updated embedded sippy/load and seed-data invocations to use --release="4.20" instead of 4.14.
Test constants
test/e2e/util/e2erequest.go
Updated constants: Release 4.144.20; BaseRelease 4.134.19.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 8
✅ Passed checks (8 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Merge Conflict Detection ✅ Passed ✅ No merge conflicts detected when merging into main
Go Error Handling ✅ Passed The pull request modifies only constant values in a Go file without introducing any error handling violations.
Sql Injection Prevention ✅ Passed Pull request modifies only configuration files, shell scripts, and test utilities with no SQL query construction or database operations present.
Excessive Css In React Should Use Styles ✅ Passed This custom check is not applicable to the provided pull request. The PR modifies only configuration files (YAML), shell scripts, and Go source files—specifically updating release version numbers from 4.14 to 4.20. None of the modified files are React components (JSX/TSX), and the repository's React components in sippy-ng/src/ are not touched by this PR. Since the check targets excessive inline CSS in React components, which are absent from these changes, the check does not apply.
Single Responsibility And Clear Naming ✅ Passed PR updates only version constants and configuration values (4.14 to 4.20) without introducing new code entities or violating naming conventions.
Title check ✅ Passed The title clearly describes the main change: updating e2e test configuration from 4.14 to 4.20 jobs across multiple files.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@ngopalak-redhat
Copy link
Copy Markdown
Contributor Author

/test e2e

@ngopalak-redhat
Copy link
Copy Markdown
Contributor Author

/test all

@ngopalak-redhat
Copy link
Copy Markdown
Contributor Author

/test e2e

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI agents
In `@config/e2e-openshift.yaml`:
- Around line 4-8: The listed 4.20 job keys (under the "4.20" map) reference job
names periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial-2of2,
periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial-1of2 and
periodic-ci-openshift-release-master-nightly-4.20-e2e-gcp-ovn-csi which may not
match the real Prow job names; verify in the OpenShift CI Prow config that these
exact job names exist and are active, and if they do not, replace them with the
correct names (e.g., the actual pattern like
periodic-ci-openshift-release-master-ci-4.20-e2e-*-ovn) or remove them from the
"4.20" map so the mapping only references valid, currently-running Prow jobs.

In `@test/e2e/util/e2erequest.go`:
- Around line 16-17: Tests use Release and BaseRelease constants ("Release" and
"BaseRelease" in e2erequest.go) that don't match any view returned by
ViewsMatchingReleases(); update either the YAML or the constants so the test
queries match an existing view: add a new view entry in e2e-views.yaml with
sample_release="4.20" and base_release="4.19" (e.g., name "4.20-main"), or
change the constants in e2erequest.go to BaseRelease="4.13" and Release="4.14"
to align with the existing "4.14-main" view so ViewsMatchingReleases() returns
data.
🧹 Nitpick comments (1)
scripts/e2e.sh (1)

57-62: Import time may increase significantly with release 4.20.

The comment states older releases are used because they "have very few job runs and thus import quickly, ~5 minutes." Release 4.20 is newer and likely has more job runs, which could substantially increase import time and affect local developer experience.

Consider updating the comment to reflect the expected import time for 4.20, or verify the actual import duration.

Comment thread config/e2e-openshift.yaml
Comment on lines +4 to +8
"4.20":
jobs:
periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-sdn-serial: true
periodic-ci-openshift-release-master-ci-4.14-e2e-azure-ovn-upgrade: true
periodic-ci-openshift-release-master-nightly-4.14-e2e-gcp-sdn: true
periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial-2of2: true
periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial-1of2: true
periodic-ci-openshift-release-master-nightly-4.20-e2e-gcp-ovn-csi: true
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🌐 Web query:

OpenShift CI prow jobs 4.20 e2e-aws-ovn e2e-gcp-ovn

💡 Result:

OpenShift CI (Prow) jobs for OCP 4.20 OVN E2E

  • AWS OVN (periodic/blocking on 4.20 nightlies): periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn [1]
  • GCP OVN (periodic): periodic-ci-openshift-release-master-ci-4.20-e2e-gcp-ovn [2]

PR (pull) job examples (release-4.20 branch):

  • GCP OVN: pull-ci-openshift-origin-release-4.20-e2e-gcp-ovn [3]
  • AWS OVN variant found (FIPS): pull-ci-openshift-origin-release-4.20-e2e-aws-ovn-fips [4]

References:
[1] (amd64.ocp.releases.ci.openshift.org)
[2] (prow.ci.openshift.org)
[3] (deck-ci.apps.ci.l2s4.p1.openshiftapps.com)
[4] (deck-ci.apps.ci.l2s4.p1.openshiftapps.com)

Citations:


🏁 Script executed:

# Search the codebase for references to these job names or similar patterns
rg "periodic-ci-openshift-release-master-nightly-4\.(20|14)" --type yaml -A 2 -B 2

Repository: openshift/sippy

Length of output: 458


🏁 Script executed:

# Check if there's a job configuration or registry in the codebase
fd -e yaml -e json | xargs grep -l "periodic-ci-openshift-release.*4\.(14|20)" 2>/dev/null | head -20

Repository: openshift/sippy

Length of output: 41


Verify job names match actual OpenShift CI Prow configuration.

The job names reference master-nightly variants with -serial-2of2, -serial-1of2, and -csi suffixes, but OpenShift CI 4.20 OVN jobs appear to follow the pattern periodic-ci-openshift-release-master-ci-4.20-e2e-*-ovn without these suffixes. Confirm these specific job name variants (periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial-2of2, periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial-1of2, and periodic-ci-openshift-release-master-nightly-4.20-e2e-gcp-ovn-csi) exist in Prow configuration and are actively running.

🤖 Prompt for AI Agents
In `@config/e2e-openshift.yaml` around lines 4 - 8, The listed 4.20 job keys
(under the "4.20" map) reference job names
periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial-2of2,
periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial-1of2 and
periodic-ci-openshift-release-master-nightly-4.20-e2e-gcp-ovn-csi which may not
match the real Prow job names; verify in the OpenShift CI Prow config that these
exact job names exist and are active, and if they do not, replace them with the
correct names (e.g., the actual pattern like
periodic-ci-openshift-release-master-ci-4.20-e2e-*-ovn) or remove them from the
"4.20" map so the mapping only references valid, currently-running Prow jobs.

Comment thread test/e2e/util/e2erequest.go
@ngopalak-redhat
Copy link
Copy Markdown
Contributor Author

/test e2e

1 similar comment
@ngopalak-redhat
Copy link
Copy Markdown
Contributor Author

/test e2e

@ngopalak-redhat
Copy link
Copy Markdown
Contributor Author

/test e2e

@ngopalak-redhat ngopalak-redhat changed the title WIP: e2e test Fix e2e: Use a 4.20 jobs instead of 4.14 in e2etest Feb 13, 2026
@ngopalak-redhat ngopalak-redhat marked this pull request as ready for review February 13, 2026 11:09
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 13, 2026
@openshift-ci openshift-ci bot requested review from deepsm007 and smg247 February 13, 2026 11:10
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 13, 2026

@ngopalak-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@neisw
Copy link
Copy Markdown
Contributor

neisw commented Feb 13, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 13, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neisw, ngopalak-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit e84e600 into openshift:main Feb 13, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants