CVO: Use golangci-lint:v2.3.1 in CI #73631
Conversation
|
/pj-rehearse |
|
@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongkailiu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/pj-rehearse pull-ci-openshift-cluster-version-operator-main-lint |
|
@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
| name: golangci-lint | ||
| namespace: ci | ||
| tag: v1.64.8 | ||
| tag: latest |
There was a problem hiding this comment.
I am personally inclined to use explicit versions. This protects us from randomly failing CI during a development cycle every time there is a bump to the golangci-lint, which finds some issues. It usually results in us fixing the failing CI due to linting issues only when bumping the Go version, which, on its own, represents some amount of work. This simply means we can fix linting issues only when bumping Go, and we can anticipate this, and I don't find linting issues to be urgent. I find it personally less annoying this way; however, if you find it more useful this way, I am open to approving the PR.
There was a problem hiding this comment.
I am personally inclined to use explicit versions.
Totally agree: Fix lint issue with our own pace. But currently there is no versions in between at the moment. :)
And I just want to fix the lint job and unblock merging to CVO.
The attempt to use latest failed anyway as our code is not ready.
Chicken and egg situation for us now.
bd47e2e to
35b7b07
Compare
|
/pj-rehearse pull-ci-openshift-cluster-version-operator-main-lint |
|
@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/hold |
181ae1f to
35b7b07
Compare
|
/pj-rehearse pull-ci-openshift-cluster-version-operator-main-lint |
|
@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
This is to fix ``` Error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0) Failed executing command with error: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0) ``` from the job [1] after bumping to Go1.25. [1]. https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-version-operator/1288/pull-ci-openshift-cluster-version-operator-main-lint/2012180966650417152
35b7b07 to
6ad6c5f
Compare
|
/pj-rehearse pull-ci-openshift-cluster-version-operator-main-lint |
|
@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-cluster-version-operator-main-lint |
|
@hongkailiu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@hongkailiu: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is to fix
from the job [1] after bumping to Go1.25.
Requiring #73655
[1]. https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-version-operator/1288/pull-ci-openshift-cluster-version-operator-main-lint/2012180966650417152