NO-JIRA: Disable informing tests for the time being by jcaamano · Pull Request #3118 · openshift/ovn-kubernetes

jcaamano · 2026-04-06T15:18:20Z

Until we decide when it is the best time to run them

Summary by CodeRabbit

Tests
- Modified test filtering to exclude informing-type test specs from extension tests, preventing their unintended execution alongside other test suites.

Until we decide when it is the best time to run them Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>

coderabbitai · 2026-04-06T15:18:39Z

Walkthrough

The test-spec filtering logic has been enhanced to exclude all specifications with LifecycleInforming lifecycle status before applying the existing disabled-name check, preventing informing-type specs from being included in the extension test suite.

Changes

Cohort / File(s)	Summary
Test Lifecycle Filtering `openshift/cmd/ovn-kubernetes-tests-ext/main.go`	Added predicate condition to exclude specs with `extensiontests.LifecycleInforming` lifecycle from the test selection logic.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐰 Hop, hop, filtering we go,
Informing specs now say hello to the door,
Just five little lines, a logical flow,
Extension tests cleaner than ever before! 🎯

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and accurately describes the main change: disabling informing tests temporarily.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

🧹 Nitpick comments (1)

openshift/cmd/ovn-kubernetes-tests-ext/main.go (1)

96-103: Implementation is correct; consider adding a tracking reference.

The filter logic correctly excludes informing specs as intended. Since this is a temporary measure ("for now"), consider adding a TODO with an issue reference or link to track when this should be re-enabled, which will help ensure it doesn't remain disabled indefinitely.

 	specs = specs.Select(func(spec *extensiontests.ExtensionTestSpec) bool {
-		// Disable informing specs for now
+		// TODO: Re-enable informing specs once timing is decided
+		// See: <issue_link_or_description>
 		if spec.Lifecycle == extensiontests.LifecycleInforming {
 			return false
 		}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@openshift/cmd/ovn-kubernetes-tests-ext/main.go` around lines 96 - 103, The
filter currently excludes informing specs by checking spec.Lifecycle ==
extensiontests.LifecycleInforming and disabled names via
strings.Contains(spec.Name, "[Disabled:"); add a clear TODO comment above this
specs = specs.Select(...) block referencing an issue/PR or tracking link (e.g.,
TODO: re-enable informing specs - track in ISSUE-123 or link) so this temporary
change is tracked; keep the existing logic intact and ensure the TODO includes
who/when should revisit or an issue ID to avoid it being left disabled
indefinitely.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@openshift/cmd/ovn-kubernetes-tests-ext/main.go`:
- Around line 96-103: The filter currently excludes informing specs by checking
spec.Lifecycle == extensiontests.LifecycleInforming and disabled names via
strings.Contains(spec.Name, "[Disabled:"); add a clear TODO comment above this
specs = specs.Select(...) block referencing an issue/PR or tracking link (e.g.,
TODO: re-enable informing specs - track in ISSUE-123 or link) so this temporary
change is tracked; keep the existing logic intact and ensure the TODO includes
who/when should revisit or an issue ID to avoid it being left disabled
indefinitely.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: cea7ebec-181e-4969-8531-c926c0a38c47

📥 Commits

Reviewing files that changed from the base of the PR and between ee514f9 and d2aab21.

📒 Files selected for processing (1)

openshift/cmd/ovn-kubernetes-tests-ext/main.go

openshift-ci · 2026-04-06T15:25:34Z

@jcaamano: This PR was included in a payload test run from openshift/origin#30560
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-bm

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d8ab2420-31cc-11f1-95e1-e066ee5e05ce-0

pperiyasamy · 2026-04-07T07:18:16Z

/retest

pperiyasamy · 2026-04-07T14:54:46Z

/retest-required

jcaamano · 2026-04-07T15:17:34Z

/override ci/prow/e2e-metal-ipi-ovn-dualstack-bgp
/override ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw

openshift/origin#30961

openshift-ci · 2026-04-07T15:17:57Z

@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/e2e-metal-ipi-ovn-dualstack-bgp, ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw

Details

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-dualstack-bgp
/override ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2026-04-07T15:18:00Z

@jcaamano: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-rhcos10-techpreview	`d2aab21`	link	false	`/test e2e-aws-ovn-rhcos10-techpreview`
ci/prow/security	`d2aab21`	link	false	`/test security`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-04-07T15:18:15Z

@jcaamano: This pull request explicitly references no jira issue.

Details

In response to this:

Until we decide when it is the best time to run them

Summary by CodeRabbit

Tests

Modified test filtering to exclude informing-type test specs from extension tests, preventing their unintended execution alongside other test suites.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jcaamano · 2026-04-07T15:18:56Z

/verified by #3118 (comment)

openshift-ci-robot · 2026-04-07T15:19:10Z

@jcaamano: This PR has been marked as verified by https://github.com/openshift/ovn-kubernetes/pull/3118#issuecomment-4193115006.

Details

In response to this:

/verified by #3118 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pperiyasamy · 2026-04-07T15:23:55Z

/lgtm

openshift-ci · 2026-04-07T15:24:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, pperiyasamy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [jcaamano]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tssurya · 2026-04-07T21:02:38Z


 	specs = specs.Select(func(spec *extensiontests.ExtensionTestSpec) bool {
+		// Disable informing specs for now
+		if spec.Lifecycle == extensiontests.LifecycleInforming {


what are the informing tests that we disabled in this PR? not sure if I missed this discussion/headsup in team meeting

TRT was not fond of our idea to run tests be default and let them fail as informing. so now this PR is going to make sure if they are labeled informing they will be skipped.

TRT slack thread
mentioned in my PTO update

I think there may be a way we can still let informing tests run in our own presubmits though. I will look in to that.

Disable informing tests for the time being

d2aab21

Until we decide when it is the best time to run them Signed-off-by: Jaime Caamaño Ruiz <jcaamano@redhat.com>

openshift-ci bot requested review from kyrtapz and martinkennelly April 6, 2026 15:19

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2026

coderabbitai bot reviewed Apr 6, 2026

View reviewed changes

jcaamano mentioned this pull request Apr 6, 2026

CORENET-6168: Add ovn tests extension openshift/origin#30560

Merged

jcaamano changed the title ~~Disable informing tests for the time being~~ NO-JIRA: Disable informing tests for the time being Apr 7, 2026

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 7, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 7, 2026

openshift-ci bot assigned pperiyasamy Apr 7, 2026

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2026

openshift-merge-bot bot merged commit 0c4c580 into openshift:master Apr 7, 2026
32 of 34 checks passed

tssurya reviewed Apr 7, 2026

View reviewed changes

tssurya mentioned this pull request Apr 7, 2026

NO-JIRA: DownStream Merge [04-02-2026] #3114

Merged

5 tasks

Conversation

jcaamano commented Apr 6, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Apr 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Apr 6, 2026

Uh oh!

pperiyasamy commented Apr 7, 2026

Uh oh!

pperiyasamy commented Apr 7, 2026

Uh oh!

jcaamano commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Apr 7, 2026

Uh oh!

openshift-ci bot commented Apr 7, 2026

Uh oh!

openshift-ci-robot commented Apr 7, 2026

Summary by CodeRabbit

Uh oh!

jcaamano commented Apr 7, 2026

Uh oh!

openshift-ci-robot commented Apr 7, 2026

Uh oh!

pperiyasamy commented Apr 7, 2026

Uh oh!

openshift-ci bot commented Apr 7, 2026

Uh oh!

Uh oh!

tssurya Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jluhrsen Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jcaamano commented Apr 6, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 6, 2026 •

edited

Loading

jcaamano commented Apr 7, 2026 •

edited

Loading

tssurya Apr 7, 2026 •

edited

Loading