Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions OWNERS_ALIASES
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
aliases:
srep-functional-team-aurora:
- abyrne55
- AlexSmithGH
- dakotalongRH
- eth1030
- joshbranham
- luis-falcon
- reedcort
Expand Down Expand Up @@ -65,14 +67,12 @@ aliases:
- feichashao
- samanthajayasinghe
- xiaoyu74
- Dee-6777
- Tessg22
- smarthall
srep-infra-cicd:
- ritmun
- yiqinzhang
- varunraokadaparthi
- christophermancini
srep-functional-leads:
- abyrne55
- clcollins
Expand Down
2 changes: 1 addition & 1 deletion boilerplate/_data/last-boilerplate-commit
Original file line number Diff line number Diff line change
@@ -1 +1 @@
d7285a904eda6cf842ddff8c648dedb223934a75
b1c2b442985aaf395dde19b28fa5f139563eda05
15 changes: 12 additions & 3 deletions boilerplate/_lib/container-make
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ if [[ "$1" == "-h"* ]] || [[ "$1" == "--h"* ]]; then
echo "Usage: $0 {arguments to the real 'make'}"
echo "Runs 'make' in the boilerplate backing container."
echo "If the command fails, starts a shell in the container so you can debug."
echo "Set NONINTERACTIVE=true (or TRUE) to skip the debug shell and exit with the make return code."
exit -1
fi

Expand Down Expand Up @@ -40,12 +41,20 @@ banner "Running: make $@"
$CONTAINER_ENGINE $args make "$@"
rc=$?

# If it failed, drop into the container in a shell
# If it failed, check if we should drop into a shell or exit
if [[ $rc -ne 0 ]]; then
banner "The 'make' command failed! Starting a shell in the container for debugging. Just 'exit' when done."
$CONTAINER_ENGINE $args /bin/bash
# Case-insensitive check for NONINTERACTIVE (true, TRUE, True all work)
if [[ "${NONINTERACTIVE,,}" == "true" ]]; then
banner "The 'make' command failed with exit code $rc. Skipping debug shell (NONINTERACTIVE=${NONINTERACTIVE})."
else
banner "The 'make' command failed! Starting a shell in the container for debugging. Just 'exit' when done."
$CONTAINER_ENGINE $args /bin/bash
fi
fi

# Finally, remove the container
banner "Cleaning up the container"
$CONTAINER_ENGINE rm -f $container_id >/dev/null

# Exit with the return code from make
exit $rc
2 changes: 1 addition & 1 deletion boilerplate/openshift/golang-osd-e2e/update
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ OPERATOR_NAME_CAMEL_CASE=${OPERATOR_PROPER_NAME// /}

mkdir -p "${E2E_SUITE_DIRECTORY}"

E2E_SUITE_BUILDER_IMAGE=registry.ci.openshift.org/openshift/release:rhel-9-release-golang-1.24-openshift-4.20
E2E_SUITE_BUILDER_IMAGE=registry.ci.openshift.org/openshift/release:rhel-9-release-golang-1.24-openshift-4.21
if [[ -n ${KONFLUX_BUILDS} ]]; then
E2E_SUITE_BUILDER_IMAGE="brew.registry.redhat.io/rh-osbs/openshift-golang-builder:rhel_9_1.24"
fi
Expand Down
3 changes: 2 additions & 1 deletion boilerplate/openshift/golang-osd-operator/OWNERS_ALIASES
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
aliases:
srep-functional-team-aurora:
- abyrne55
- AlexSmithGH
- dakotalongRH
- eth1030
- joshbranham
- luis-falcon
- reedcort
Expand Down Expand Up @@ -65,7 +67,6 @@ aliases:
- feichashao
- samanthajayasinghe
- xiaoyu74
- Dee-6777
- Tessg22
- smarthall
srep-infra-cicd:
Expand Down
6 changes: 6 additions & 0 deletions boilerplate/openshift/golang-osd-operator/standard.mk
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,7 @@ endif
# Boilerplate container-make targets.
# Runs 'make' in the boilerplate backing container.
# If the command fails, starts a shell in the container so you can debug.
# Set NONINTERACTIVE=true to skip the debug shell for CI/automation.
.PHONY: container-test
container-test:
${BOILERPLATE_CONTAINER_MAKE} test
Expand All @@ -384,6 +385,11 @@ container-validate:
container-coverage:
${BOILERPLATE_CONTAINER_MAKE} coverage

# Run all container-* validation targets in sequence.
# Set NONINTERACTIVE=true to skip debug shells and fail fast for CI/automation.
.PHONY: container-all
container-all: container-lint container-generate container-coverage container-test container-validate

.PHONY: rvmo-bundle
rvmo-bundle:
RELEASE_BRANCH=$(RELEASE_BRANCH) \
Expand Down
2 changes: 1 addition & 1 deletion build/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ COPY . /osd-example-operator
WORKDIR /osd-example-operator
RUN make go-build

FROM registry.access.redhat.com/ubi9/ubi-minimal:9.6-1758184547
FROM registry.access.redhat.com/ubi9/ubi-minimal:9.7-1763362218
ENV OPERATOR=/usr/local/bin/osd-example-operator \
USER_UID=1001 \
USER_NAME=osd-example-operator
Expand Down
2 changes: 1 addition & 1 deletion build/Dockerfile.olm-registry
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ COPY ${SAAS_OPERATOR_DIR} manifests
RUN initializer --permissive

# ubi-micro does not work for clusters with fips enabled unless we make OpenSSL available
FROM registry.access.redhat.com/ubi9/ubi-minimal:9.6-1758184547
FROM registry.access.redhat.com/ubi9/ubi-minimal:9.7-1763362218

COPY --from=builder /bin/registry-server /bin/registry-server
COPY --from=builder /bin/grpc_health_probe /bin/grpc_health_probe
Expand Down
9 changes: 0 additions & 9 deletions test/e2e/osd_example_operator_runner_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
package osde2etests

import (
"fmt"
"os"
"path/filepath"
"testing"
Expand All @@ -27,11 +26,3 @@ func TestOsdExampleOperator(t *testing.T) {
}
RunSpecs(t, "Osd Example Operator", suiteConfig, reporterConfig)
}

// Failing test case added on purpose
var _ = Describe("Intentional Failure Test", func() {
It("should fail on purpose", func() {
fmt.Println("Running Intentional Failure Test")
Expect(true).To(BeFalse(), "This test is designed to fail intentionally")
})
})
8 changes: 7 additions & 1 deletion test/e2e/osd_example_operator_tests.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ package osde2etests

import (
"context"

"fmt"
. "github.com/onsi/ginkgo/v2"
. "github.com/onsi/gomega"
)
Expand All @@ -14,4 +14,10 @@ var _ = Describe("osd-example-operator", func() {
It("asserts success", func(ctx context.Context) {
Expect(true).To(BeTrue(), "True should be true")
})

// Failing test for log analysis demo
It("should fail on purpose", func() {
fmt.Println("Running Intentional Failure Test")
Expect(true).To(BeFalse(), "This test is designed to fail intentionally")
})
})