Skip to content

OCPBUGS-81340: fix pacemaker CronJob duplicate-event namespace#30985

Open
jaypoulz wants to merge 1 commit intoopenshift:mainfrom
jaypoulz:OCPBUGS-81340-pacemaker-status-collector-events
Open

OCPBUGS-81340: fix pacemaker CronJob duplicate-event namespace#30985
jaypoulz wants to merge 1 commit intoopenshift:mainfrom
jaypoulz:OCPBUGS-81340-pacemaker-status-collector-events

Conversation

@jaypoulz
Copy link
Copy Markdown
Contributor

@jaypoulz jaypoulz commented Apr 9, 2026

The pacemaker-status-collector CronJob is created in openshift-etcd (TargetNamespace in cluster-etcd-operator). Match that namespace so SuccessfulCreate/SawCompletedJob repeats are allowed instead of rejected.

Fixes incorrect namespace in #30953

Made-with: Cursor

The pacemaker-status-collector CronJob is created in openshift-etcd
(TargetNamespace in cluster-etcd-operator). Match that namespace so
SuccessfulCreate/SawCompletedJob repeats are allowed instead of rejected.

Made-with: Cursor
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 9, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@jaypoulz: This pull request references Jira Issue OCPBUGS-81340, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

The pacemaker-status-collector CronJob is created in openshift-etcd (TargetNamespace in cluster-etcd-operator). Match that namespace so SuccessfulCreate/SawCompletedJob repeats are allowed instead of rejected.

Made-with: Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from deads2k and sjenning April 9, 2026 13:19
@dgoodwin
Copy link
Copy Markdown
Contributor

dgoodwin commented Apr 9, 2026

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, jaypoulz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 9, 2026
@jaypoulz
Copy link
Copy Markdown
Contributor Author

jaypoulz commented Apr 9, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 9, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@jaypoulz: This pull request references Jira Issue OCPBUGS-81340, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jaypoulz
Copy link
Copy Markdown
Contributor Author

jaypoulz commented Apr 9, 2026

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-techpreview

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 9, 2026

@jaypoulz: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ovn-two-node-fencing-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/38bd2c90-3417-11f1-9a5f-764e43ae4dc3-0

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2ffe3b70-17a5-4501-8325-5bb69c9686ee

📥 Commits

Reviewing files that changed from the base of the PR and between 107849e and 643060c.

📒 Files selected for processing (2)
  • pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go
  • pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_events_test.go

Walkthrough

Updated the pacemaker status collector CronJob event matcher configuration to use namespace openshift-etcd instead of openshift-etcd-operator, with corresponding test data adjustments reflecting the actual namespace where the CronJob runs.

Changes

Cohort / File(s) Summary
Pacemaker Status Collector Namespace Update
pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_event_patterns.go, pkg/monitortestlibrary/pathologicaleventlibrary/duplicated_events_test.go
Updated namespace regex for PacemakerStatusCollectorCronJobEvents matcher from ^openshift-etcd-operator$ to ^openshift-etcd$. Comment clarified to indicate CronJob runs in openshift-etcd. Test case updated with matching namespace value.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 9, 2026

@jaypoulz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-csi 643060c link true /test e2e-aws-csi
ci/prow/e2e-aws-ovn-fips 643060c link true /test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-serial-2of2 643060c link true /test e2e-aws-ovn-serial-2of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt
Copy link
Copy Markdown

openshift-trt bot commented Apr 9, 2026

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 643060c

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade Medium - "[sig-network-edge][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API functionality during upgrade" is a new test, and was only seen in one job.

New tests seen in this PR at sha: 643060c

  • "[sig-network-edge][Feature:Router][apigroup:gateway.networking.k8s.io] Verify Gateway API functionality during upgrade" [Total: 1, Pass: 1, Fail: 0, Flake: 0]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants