Skip to content

OCPNODE-3720: Test for AutoNodeSizing#30789

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
ngopalak-redhat:ngopalak/autoNode
Mar 26, 2026
Merged

OCPNODE-3720: Test for AutoNodeSizing#30789
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
ngopalak-redhat:ngopalak/autoNode

Conversation

@ngopalak-redhat
Copy link
Copy Markdown
Contributor

@ngopalak-redhat ngopalak-redhat commented Feb 16, 2026

Summary

Re-adds the auto node sizing test that was reverted in #30580, with fixes for CI failures and code refactoring.

This test validates that:

  • Node sizing is enabled by default (NODE_SIZING_ENABLED=true)
  • Users can disable it via KubeletConfig.autoSizingReserved=false

Changes

  • Creates a custom MachineConfigPool targeting a single worker node to
    minimize disruption
  • Verifies /etc/node-sizing-enabled.env file contents before and after
    KubeletConfig changes
  • Total runtime: ~5m35s (well under 40-minute budget)

Bug Fixes

    - pod-security.kubernetes.io/enforce: privileged
    - pod-security.kubernetes.io/audit: privileged
    - pod-security.kubernetes.io/warn: privileged
    - security.openshift.io/scc.podSecurityLabelSync: false
  • Handles pre-existing namespace scenario by updating labels via Get/Update
    pattern

Refactoring

  • Consolidated duplicate functions into node_utils.go

Testing

@openshift-ci-robot
Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@ngopalak-redhat ngopalak-redhat changed the title Test for AutoNodeSizing WIP: Test for AutoNodeSizing Feb 16, 2026
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 16, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 16, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ngopalak-redhat
Copy link
Copy Markdown
Contributor Author

/test all

@ngopalak-redhat
Copy link
Copy Markdown
Contributor Author

/pj-rehearse list

@ngopalak-redhat
Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning

@ngopalak-redhat
Copy link
Copy Markdown
Contributor Author

/testwith openshift/release/main/e2e-aws-disruptive-longrunning

@ngopalak-redhat
Copy link
Copy Markdown
Contributor Author

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 16, 2026

@ngopalak-redhat: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e1272140-0b60-11f1-81d0-c8556be4b24f-0

@ngopalak-redhat
Copy link
Copy Markdown
Contributor Author

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 16, 2026

@ngopalak-redhat: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7af17aa0-0b93-11f1-85a4-9ddcbb120a7f-0

@ngopalak-redhat
Copy link
Copy Markdown
Contributor Author

/test all

@ngopalak-redhat
Copy link
Copy Markdown
Contributor Author

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning
/test all

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 17, 2026

@ngopalak-redhat: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fb0b6030-0b97-11f1-9ca3-c7755568cd2c-0

@ngopalak-redhat
Copy link
Copy Markdown
Contributor Author

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning
/test all

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 17, 2026

@ngopalak-redhat: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4758ed80-0bc1-11f1-89b3-25dbfa29a094-0

@ngopalak-redhat
Copy link
Copy Markdown
Contributor Author

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 17, 2026

@ngopalak-redhat: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/80fa8820-0bd8-11f1-8d89-3eccb3c98203-0

@ngopalak-redhat
Copy link
Copy Markdown
Contributor Author

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Feb 17, 2026

@ngopalak-redhat: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cb08da00-0be4-11f1-81df-2e95b97beff5-0

@ngopalak-redhat ngopalak-redhat changed the title WIP: Test for AutoNodeSizing OCPNODE-3720: Test for AutoNodeSizing Feb 17, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 17, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 17, 2026

@ngopalak-redhat: This pull request references OCPNODE-3720 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target only the "4.22.0" version, but multiple target versions were set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ngopalak-redhat ngopalak-redhat marked this pull request as ready for review February 17, 2026 09:44
@ngopalak-redhat
Copy link
Copy Markdown
Contributor Author

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 25, 2026

@ngopalak-redhat: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9e20d030-283e-11f1-872f-8e7fcfdab5c7-0

@ngopalak-redhat
Copy link
Copy Markdown
Contributor Author

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 25, 2026

@ngopalak-redhat: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cd801b70-2847-11f1-953f-1120707ac005-0

@openshift-ci-robot
Copy link
Copy Markdown

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@ngopalak-redhat
Copy link
Copy Markdown
Contributor Author

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 25, 2026

@ngopalak-redhat: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-disruptive-longrunning

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e5e6a4c0-2862-11f1-9c39-20349b7a8b2d-0

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
test/extended/node/node_swap_cnv.go (1)

897-917: ⚠️ Potential issue | 🟠 Major

TC12 can pass without ever reaching the “OS swap disabled” scenario.

Errors from swapon -s / swapoff -a are ignored, and Lines 914-916 explicitly continue when swap is still active. That turns this spec into a false positive whenever the node cannot be driven to a swap-free baseline.

Suggested fix
-		initialSwapOutput, _ := ExecOnNodeWithChroot(oc, cnvWorkerNode, "swapon", "-s")
+		initialSwapOutput, initialSwapErr := ExecOnNodeWithChroot(oc, cnvWorkerNode, "swapon", "-s")
+		o.Expect(initialSwapErr).NotTo(o.HaveOccurred(), "must be able to inspect initial swap state")
@@
-			_, _ = ExecOnNodeWithNsenter(oc, cnvWorkerNode, "swapoff", "-a")
+			_, swapoffErr := ExecOnNodeWithNsenter(oc, cnvWorkerNode, "swapoff", "-a")
+			o.Expect(swapoffErr).NotTo(o.HaveOccurred(), "TC12 requires OS swap to be disabled")
 			framework.Logf("OS-level swap disabled")
 		}
@@
-		swapOutput, _ := ExecOnNodeWithChroot(oc, cnvWorkerNode, "swapon", "-s")
+		swapOutput, swapCheckErr := ExecOnNodeWithChroot(oc, cnvWorkerNode, "swapon", "-s")
+		o.Expect(swapCheckErr).NotTo(o.HaveOccurred(), "must be able to verify swap is disabled")
 		framework.Logf("swapon -s output:\n%s", swapOutput)
 		hasOSSwap := strings.TrimSpace(swapOutput) != "" && swapOutput != "Filename\t\t\t\tType\t\tSize\t\tUsed\t\tPriority"
 		if hasOSSwap {
-			framework.Logf("Warning: Could not disable OS swap, but continuing with test")
+			e2eskipper.Skipf("TC12 requires a node without active OS swap")
 		} else {
 			framework.Logf("Confirmed: No OS-level swap on node %s", cnvWorkerNode)
 		}
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@test/extended/node/node_swap_cnv.go` around lines 897 - 917, The test
currently ignores errors from ExecOnNodeWithChroot/ExecOnNodeWithNsenter and
treats inability to disable swap as a warning (variables initialHasSwap and
hasOSSwap), which lets TC12 falsely pass; update the logic in the block around
initialSwapOutput/initialHasSwap and the swapoff attempt so that you capture and
check the error return values from ExecOnNodeWithNsenter("swapoff", "-a") and
ExecOnNodeWithChroot("swapon", "-s"), and if swap was present (initialHasSwap)
but swapoff returned an error or subsequent swapon still indicates hasOSSwap,
fail the test (or return an error) instead of logging a warning; ensure the
failure path references the same node variable cnvWorkerNode and includes the
command error for diagnostics.
♻️ Duplicate comments (2)
test/extended/node/node_swap_cnv.go (1)

1101-1105: ⚠️ Potential issue | 🟠 Major

Check swap reset failures before each TC13 iteration.

These two commands establish the baseline for every size subtest. If either one fails, the next dd/mkswap/swapon sequence runs on leftover state and the result is unreliable.

Suggested fix
-			ExecOnNodeWithNsenter(oc, cnvWorkerNode, "swapoff", "-a")
-			ExecOnNodeWithChroot(oc, cnvWorkerNode, "rm", "-f", swapFilePath)
+			if _, err := ExecOnNodeWithNsenter(oc, cnvWorkerNode, "swapoff", "-a"); err != nil {
+				framework.Logf("Warning: failed to disable existing swap: %v", err)
+				result.success = false
+				results = append(results, result)
+				continue
+			}
+			if _, err := ExecOnNodeWithChroot(oc, cnvWorkerNode, "rm", "-f", swapFilePath); err != nil {
+				framework.Logf("Warning: failed to remove previous swap file: %v", err)
+				result.success = false
+				results = append(results, result)
+				continue
+			}
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@test/extended/node/node_swap_cnv.go` around lines 1101 - 1105, Ensure the
baseline swap cleanup commands check for failures before proceeding: after
calling ExecOnNodeWithNsenter(cnvWorkerNode, "swapoff", "-a") and
ExecOnNodeWithChroot(cnvWorkerNode, "rm", "-f", swapFilePath) (the calls shown
in the block using ExecOnNodeWithNsenter and ExecOnNodeWithChroot), verify their
return/error results and abort or fail the test (e.g., via framework.Failf or
framework.ExpectNoError) if they fail so the subsequent dd/mkswap/swapon
sequence does not run on leftover state; add clear log messages including the
node and operation when detecting an error.
test/extended/node/node_utils.go (1)

394-401: ⚠️ Potential issue | 🟠 Major

Fail installCNVOperator when the worker MCP never reconverges.

test/extended/node/node_swap_cnv.go, Lines 61-69 only abort setup when installCNVOperator returns an error. Warning-only handling here lets the CNV swap suite continue against a non-converged worker pool, which is a flaky/invalid starting state.

Suggested fix
  mcClient, err := machineconfigclient.NewForConfig(oc.AdminConfig())
  if err != nil {
  	framework.Logf("Warning: failed to create MC client for MCP check: %v", err)
  } else {
-		err = waitForMCP(ctx, mcClient, "worker", 30*time.Minute)
-		if err != nil {
-			framework.Logf("Warning: MCP rollout check failed: %v", err)
-		}
+		if err = waitForMCP(ctx, mcClient, "worker", 30*time.Minute); err != nil {
+			return fmt.Errorf("MCP rollout check failed: %w", err)
+		}
 	}
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@test/extended/node/node_utils.go` around lines 394 - 401, The current logic
logs warnings when creating the MachineConfig client or when
waitForMCP("worker", ...) fails, allowing installCNVOperator to succeed even if
the worker MCP never reconverges; change this so errors are propagated instead
of only logged: in the function that creates mcClient and calls waitForMCP
(references: mcClient and waitForMCP), return the error (or wrap and return it)
when NewForConfig or waitForMCP fail so installCNVOperator (the caller) will
abort setup on MCP non-convergence rather than continuing with warnings.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@test/extended/node/node_swap_cnv.go`:
- Around line 897-917: The test currently ignores errors from
ExecOnNodeWithChroot/ExecOnNodeWithNsenter and treats inability to disable swap
as a warning (variables initialHasSwap and hasOSSwap), which lets TC12 falsely
pass; update the logic in the block around initialSwapOutput/initialHasSwap and
the swapoff attempt so that you capture and check the error return values from
ExecOnNodeWithNsenter("swapoff", "-a") and ExecOnNodeWithChroot("swapon", "-s"),
and if swap was present (initialHasSwap) but swapoff returned an error or
subsequent swapon still indicates hasOSSwap, fail the test (or return an error)
instead of logging a warning; ensure the failure path references the same node
variable cnvWorkerNode and includes the command error for diagnostics.

---

Duplicate comments:
In `@test/extended/node/node_swap_cnv.go`:
- Around line 1101-1105: Ensure the baseline swap cleanup commands check for
failures before proceeding: after calling ExecOnNodeWithNsenter(cnvWorkerNode,
"swapoff", "-a") and ExecOnNodeWithChroot(cnvWorkerNode, "rm", "-f",
swapFilePath) (the calls shown in the block using ExecOnNodeWithNsenter and
ExecOnNodeWithChroot), verify their return/error results and abort or fail the
test (e.g., via framework.Failf or framework.ExpectNoError) if they fail so the
subsequent dd/mkswap/swapon sequence does not run on leftover state; add clear
log messages including the node and operation when detecting an error.

In `@test/extended/node/node_utils.go`:
- Around line 394-401: The current logic logs warnings when creating the
MachineConfig client or when waitForMCP("worker", ...) fails, allowing
installCNVOperator to succeed even if the worker MCP never reconverges; change
this so errors are propagated instead of only logged: in the function that
creates mcClient and calls waitForMCP (references: mcClient and waitForMCP),
return the error (or wrap and return it) when NewForConfig or waitForMCP fail so
installCNVOperator (the caller) will abort setup on MCP non-convergence rather
than continuing with warnings.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f19de946-a931-414e-9073-53628a3894c4

📥 Commits

Reviewing files that changed from the base of the PR and between f736466 and 9cb3ad9.

📒 Files selected for processing (4)
  • test/extended/node/node_e2e/node.go
  • test/extended/node/node_sizing.go
  • test/extended/node/node_swap_cnv.go
  • test/extended/node/node_utils.go

@openshift-ci-robot
Copy link
Copy Markdown

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 26, 2026

@ngopalak-redhat: This pull request references OCPNODE-3720 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target only the "4.22.0" version, but multiple target versions were set.

Details

In response to this:

Summary

Re-adds the auto node sizing test that was reverted in #30580, with fixes for CI failures and code refactoring.

This test validates that:

  • Node sizing is enabled by default (NODE_SIZING_ENABLED=true)
  • Users can disable it via KubeletConfig.autoSizingReserved=false

Changes

  • Creates a custom MachineConfigPool targeting a single worker node to
    minimize disruption
  • Verifies /etc/node-sizing-enabled.env file contents before and after
    KubeletConfig changes
  • Total runtime: ~5m35s (well under 40-minute budget)

Bug Fixes

   - pod-security.kubernetes.io/enforce: privileged
   - pod-security.kubernetes.io/audit: privileged
   - pod-security.kubernetes.io/warn: privileged
   - security.openshift.io/scc.podSecurityLabelSync: false
  • Handles pre-existing namespace scenario by updating labels via Get/Update
    pattern

Refactoring

  • Consolidated duplicate functions into node_utils.go

Testing

Related

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 26, 2026

@ngopalak-redhat: This pull request references OCPNODE-3720 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target only the "4.22.0" version, but multiple target versions were set.

Details

In response to this:

Summary

Re-adds the auto node sizing test that was reverted in #30580, with fixes for CI failures and code refactoring.

This test validates that:

  • Node sizing is enabled by default (NODE_SIZING_ENABLED=true)
  • Users can disable it via KubeletConfig.autoSizingReserved=false

Changes

  • Creates a custom MachineConfigPool targeting a single worker node to
    minimize disruption
  • Verifies /etc/node-sizing-enabled.env file contents before and after
    KubeletConfig changes
  • Total runtime: ~5m35s (well under 40-minute budget)

Bug Fixes

   - pod-security.kubernetes.io/enforce: privileged
   - pod-security.kubernetes.io/audit: privileged
   - pod-security.kubernetes.io/warn: privileged
   - security.openshift.io/scc.podSecurityLabelSync: false
  • Handles pre-existing namespace scenario by updating labels via Get/Update
    pattern

Refactoring

  • Consolidated duplicate functions into node_utils.go

Testing

Related

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ngopalak-redhat
Copy link
Copy Markdown
Contributor Author

/retest-required

@ngopalak-redhat
Copy link
Copy Markdown
Contributor Author

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Mar 26, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@ngopalak-redhat: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci
https://pr-payload-tests.ci.openshift.org/runs/ci/e5e6a4c0-2862-11f1-9c39-20349b7a8b2d-0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ngopalak-redhat
Copy link
Copy Markdown
Contributor Author

/assign @BhargaviGudi

@ngopalak-redhat
Copy link
Copy Markdown
Contributor Author

cc: @cpmeadors

@BhargaviGudi
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2026
@openshift-trt
Copy link
Copy Markdown

openshift-trt bot commented Mar 26, 2026

Risk analysis has seen new tests most likely introduced by this PR.
Please ensure that new tests meet guidelines for naming and stability.

New Test Risks for sha: 9cb3ad9

Job Name New Test Risk
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi High - "[sig-storage][Feature:StorageBinaries][Jira:Storage] should have required storage binaries on node [Suite:openshift/conformance/parallel]" is a new test that was not present in all runs against the current commit.

New tests seen in this PR at sha: 9cb3ad9

  • "[sig-storage][Feature:StorageBinaries][Jira:Storage] should have required storage binaries on node [Suite:openshift/conformance/parallel]" [Total: 2, Pass: 2, Fail: 0, Flake: 0]

@cpmeadors
Copy link
Copy Markdown
Contributor

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 26, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BhargaviGudi, cpmeadors, ngopalak-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 26, 2026

@ngopalak-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit a209706 into openshift:main Mar 26, 2026
21 checks passed
Chandan9112 pushed a commit to Chandan9112/origin that referenced this pull request Mar 31, 2026
…Node

OCPNODE-3720: Test for AutoNodeSizing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants