OCPBUGS-57348: Cluster manages bootimages despite explicit bootimages in installconfig#5120
OCPBUGS-57348: Cluster manages bootimages despite explicit bootimages in installconfig#5120djoshy wants to merge 3 commits intoopenshift:mainfrom
Conversation
|
@djoshy: This pull request references Jira Issue OCPBUGS-57348, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.19-e2e-rosa-sts-ovn |
|
@djoshy: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/b8aee040-4874-11f0-9439-43db3895c78e-0 |
yuqi-zhang
left a comment
There was a problem hiding this comment.
lgtm, there seems to be a failure with go deps verify-deps. Could you check on that?
pkg/helpers/helpers.go
Outdated
| return false, nil | ||
| } | ||
|
|
||
| // Ignore control place changes until MCO-1007 is completed. |
There was a problem hiding this comment.
nit:
| // Ignore control place changes until MCO-1007 is completed. | |
| // Ignore control plane changes until MCO-1007 is completed. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: djoshy, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@djoshy: An error was encountered querying GitHub for users with public email (gpei@redhat.com) for bug OCPBUGS-57348 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details. Full error message.
Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: connect: connection refused
Please contact an administrator to resolve this issue, then request a bug refresh with DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@djoshy: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/close closing in favor of openshift/installer#9783 |
|
@djoshy: This pull request references Jira Issue OCPBUGS-57348. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@djoshy: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Closes https://issues.redhat.com//browse/OCPBUGS-57348
- What I did
Added install config CM detection during the boot image opt-in evaluation . If a boot image specified in the InstallConfig, the MCO will prevent the opt-in. This should also work on upgrades.
- How to verify it
Bring up a 4.20/4.19 AWS/GCP cluster with install-config parameters for boot images(see bug). The MCO should not opt-in the cluster for boot image updates by default. The same should be true for upgrades from 4.18->4.19.