Skip to content

Tighten raise-pr skill with branch guard and existing PR check#2797

Open
onmete wants to merge 2 commits intoopenshift:mainfrom
onmete:chore/tighten-raise-pr-skill
Open

Tighten raise-pr skill with branch guard and existing PR check#2797
onmete wants to merge 2 commits intoopenshift:mainfrom
onmete:chore/tighten-raise-pr-skill

Conversation

@onmete
Copy link
Contributor

@onmete onmete commented Mar 5, 2026

Description

Tightens the .cursor/skills/raise-pr/SKILL.md workflow to prevent changes from being pushed to the wrong branch or bundled into an existing PR.

Changes:

  • Step 1 now runs gh pr list --head to detect any open PR on the current branch before proceeding
  • Step 2 flips the default: a new branch from main is always created unless the user explicitly confirms otherwise
  • The user prompt surfaces a warning when an existing open PR is detected on the current branch
  • Step 5 adds an explicit guard against using gh pr edit or pushing to a branch that already has an open PR
  • Renumbered all steps to stay sequential (1–6)

Type of change

  • Configuration Update

Related Tickets & Documents

  • N/A

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

This is a Cursor skill (markdown workflow file) with no executable code. Verified by reviewing the updated step-by-step instructions directly.

Made with Cursor

@openshift-ci openshift-ci bot requested review from joshuawilson and xrajesh March 5, 2026 11:55
@openshift-ci
Copy link

openshift-ci bot commented Mar 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joshuawilson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@onmete onmete force-pushed the chore/tighten-raise-pr-skill branch from f754bf7 to e507f31 Compare March 5, 2026 12:06
@openshift-ci
Copy link

openshift-ci bot commented Mar 5, 2026

@onmete: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@onmete
Copy link
Contributor Author

onmete commented Mar 5, 2026

unrelated
/override "Red Hat Konflux / lightspeed-service-on-pull-request"

@openshift-ci
Copy link

openshift-ci bot commented Mar 5, 2026

@onmete: Overrode contexts on behalf of onmete: Red Hat Konflux / lightspeed-service-on-pull-request

Details

In response to this:

unrelated
/override "Red Hat Konflux / lightspeed-service-on-pull-request"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant