docs_summarizer.iterate_with_tools method refactoring#2783
docs_summarizer.iterate_with_tools method refactoring#2783blublinsky wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test evaluation |
|
/test ols-evaluation |
|
/retest |
4ec11d9 to
d12135a
Compare
|
/retest |
|
/test integration |
d12135a to
b24a7cd
Compare
|
/retest |
|
/retest |
| system_prompt: Optional[str] = None | ||
| attachments: Optional[list[Attachment]] = None | ||
| media_type: Optional[str] = MEDIA_TYPE_TEXT | ||
| media_type: Optional[str] = MEDIA_TYPE_JSON |
There was a problem hiding this comment.
Why was this default changed?
There was a problem hiding this comment.
UI is using JSON, not text
985cb99 to
0f9b01e
Compare
0f9b01e to
f44a95f
Compare
|
/retest |
f44a95f to
9776731
Compare
|
@blublinsky: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
This is initial refactoring of iterate with tools to prepare for tools approval
It is mostly splitting existing iterate with tools method into multiple functions. Preserving the current logic (for the most part), but restructuring it from one massive function into several smaller ones
Type of change
Related Tickets & Documents
OLS-2659OLS-2659
Checklist before requesting a review
Testing