OLS-2504 - Adding adaptation to lcore tests - WIP by JoaoFula · Pull Request #2713 · openshift/lightspeed-service

JoaoFula · 2026-01-23T10:32:00Z

Description

Type of change

Related Tickets & Documents

Related Issue #
Closes #

Checklist before requesting a review

I have performed a self-review of my code.
PR has passed all pre-merge test jobs.
If it is a core feature, I have added thorough tests.

Testing

Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

openshift-ci · 2026-01-27T11:05:08Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xrajesh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

JoaoFula · 2026-02-02T09:24:25Z

/retest

JoaoFula · 2026-02-03T07:38:21Z

TODO:
As a follow up, we should remove the update_ols_config() from ols_installer and adapt_ols_config and just have this run as a fixture or being called in the data_collection test. It will simplify the installer files.

JoaoFula · 2026-02-03T11:20:05Z

/retest

JoaoFula · 2026-02-06T14:21:42Z

/retest

JoaoFula · 2026-02-16T09:08:54Z

/retest

JoaoFula · 2026-02-18T12:15:23Z

/retest

JoaoFula · 2026-02-19T14:00:10Z

/retest

JoaoFula · 2026-02-23T12:09:46Z

/retest

JoaoFula · 2026-02-23T16:07:20Z

/retest

JoaoFula · 2026-02-27T08:30:04Z

/retest

JoaoFula · 2026-02-27T10:27:41Z

/retest

deactivating more tests

Removing bundle sync configuration from console tests. Just run the tests in main. Removing bundle sync configuration from console tests. Just run the tests in main. Removing bundle sync configuration from console tests. Just run the tests in main. Removing bundle sync configuration from console tests. Just run the tests in main. Adding obs owners for access to cluster pool logs Adding obs owners for access to cluster pool logs Adding obs owners for access to cluster pool logs

Deactivating operator pod for data collection test

…ool calling enabled

JoaoFula · 2026-02-27T14:24:08Z

/retest

onmete · 2026-03-02T09:46:27Z

/test e2e-ols-cluster

onmete · 2026-03-02T13:03:50Z

tests/e2e/utils/cluster.py

    )
    if not r:
-        raise Exception("Timed out waiting for new OLS pod to be ready")
+        raise Exception("Timed out waiting for {name} pod to be ready")


Missing f

onmete · 2026-03-02T13:05:30Z

tests/e2e/utils/adapt_ols_config.py

    # Update configmap with e2e-specific settings - FAIL FAST if this breaks
    print("Updating configmap with e2e test settings...")
-    update_ols_configmap()
+    if OLS_SERVICE_DEPLOYMENT == "lightspeed-app-server":


How reliable is this condition? Should it be if not lcore_enabled?

might be reliable but makes no sense when we have lcore_enabled. Good catch

onmete · 2026-03-02T13:05:45Z

tests/e2e/utils/cluster.py

    )
    if not r:
-        raise Exception("Timed out waiting for new OLS pod to be ready")
+        raise Exception("Timed out waiting for {name} pod to be ready")


Missing f.

onmete · 2026-03-02T13:08:52Z

tests/e2e/utils/ols_installer.py


    provider = os.getenv("PROVIDER", "openai")
    creds = os.getenv("PROVIDER_KEY_PATH", "empty")
+    update_lcore_setting()


Do we want to always executed this?

if lcore_enabled: update_lcore_setting()

And the update_lcore_setting is doing another check like lcore_enabled from env vars. Can we reuse a single constant defining if lcore is on/off through all places?

onmete · 2026-03-02T13:15:34Z

tests/e2e/utils/adapt_ols_config.py

            "deployment/lightspeed-operator-controller-manager",
            "--replicas",
-            "0",
+            "1",


This should be 0 - this seems to be the cause of failures in the E2E.

openshift-ci · 2026-03-02T17:06:30Z

@JoaoFula: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify	`27be98b`	link	true	`/test verify`
ci/prow/e2e-ols-cluster	`27be98b`	link	true	`/test e2e-ols-cluster`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

JoaoFula marked this pull request as draft January 23, 2026 10:32

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2026

openshift-ci bot requested review from onmete and xrajesh January 23, 2026 10:32

JoaoFula force-pushed the lcore-tests-adaptation branch from 7e230e6 to fbc9a3d Compare January 23, 2026 15:12

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 25, 2026

JoaoFula force-pushed the lcore-tests-adaptation branch from cc83464 to 9624157 Compare January 27, 2026 11:10

JoaoFula marked this pull request as ready for review January 27, 2026 11:10

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2026

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 27, 2026

openshift-ci bot requested a review from raptorsun January 27, 2026 11:11

JoaoFula force-pushed the lcore-tests-adaptation branch 7 times, most recently from 0e7bd31 to 0442f58 Compare January 29, 2026 10:42

JoaoFula force-pushed the lcore-tests-adaptation branch from 8b7483a to a22b712 Compare February 3, 2026 07:37

JoaoFula force-pushed the lcore-tests-adaptation branch from a22b712 to 94d46ff Compare February 18, 2026 09:05

JoaoFula added 5 commits February 27, 2026 14:39

Adding adaptation to lcore tests

9ae1a66

deactivating more tests

Adding more lcore skips and fixing some tests to pass with lcore

83fe27a

Deactivating operator pod for data collection test

c68052a

Deactivating operator pod for data collection test

fixing bug where we waited for two containers for operator pod when t…

bfe0272

…ool calling enabled

JoaoFula force-pushed the lcore-tests-adaptation branch from ee43854 to bfe0272 Compare February 27, 2026 13:39

onmete reviewed Mar 2, 2026

View reviewed changes

Adding changes based on comments

27be98b

Conversation

JoaoFula commented Jan 23, 2026

Description

Type of change

Related Tickets & Documents

Checklist before requesting a review

Testing

Uh oh!

openshift-ci bot commented Jan 27, 2026

Uh oh!

JoaoFula commented Feb 2, 2026

Uh oh!

JoaoFula commented Feb 3, 2026

Uh oh!

JoaoFula commented Feb 3, 2026

Uh oh!

JoaoFula commented Feb 6, 2026

Uh oh!

JoaoFula commented Feb 16, 2026

Uh oh!

JoaoFula commented Feb 18, 2026

Uh oh!

JoaoFula commented Feb 19, 2026

Uh oh!

JoaoFula commented Feb 23, 2026

Uh oh!

JoaoFula commented Feb 23, 2026

Uh oh!

JoaoFula commented Feb 27, 2026

Uh oh!

JoaoFula commented Feb 27, 2026

Uh oh!

JoaoFula commented Feb 27, 2026

Uh oh!

onmete commented Mar 2, 2026

Uh oh!

onmete Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

onmete Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

JoaoFula Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

onmete Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

onmete Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

onmete Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Mar 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants