OCPBUGS-57535: vSphere - remove unit tests using nip.io#9793
OCPBUGS-57535: vSphere - remove unit tests using nip.io#9793openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
|
@jcpowermac: This pull request references Jira Issue OCPBUGS-57535, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@jcpowermac: This pull request references Jira Issue OCPBUGS-57535, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/assign @patrickdillon |
| installConfig: func() *types.InstallConfig { | ||
| installConfig := validIPIInstallConfig() | ||
| installConfig.ObjectMeta.Name = "0a000803" | ||
| installConfig.BaseDomain = wildcardDNS |
There was a problem hiding this comment.
I guess we can remove:
The hex based dns service is no longer available and the replacement service does not take PRs or looks interested in this feature. If we want this unit test in the future we will need to think through how to implement this.
b5d52b5 to
343de76
Compare
|
@jcpowermac: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vr4manta The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bc941c8
into
openshift:main
|
@jcpowermac: Jira Issue OCPBUGS-57535: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-57535 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer |
|
[ART PR BUILD NOTIFIER] Distgit: ose-baremetal-installer |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-artifacts |
|
/cherry-pick release-4.19 |
|
@jcpowermac: new pull request created: #9802 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The hex based dns service is no longer available
and the replacement service does not take PRs
or looks interested in this feature.
If we want this unit test in the future we will need to think through how to implement this.