SDCICD-1772 add template for full healthcheck#437
SDCICD-1772 add template for full healthcheck#437openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
Conversation
joshbranham
left a comment
There was a problem hiding this comment.
Which piece in here tells it to use a full cluster health check?
| - name: LOG_BUCKET | ||
| value: 'osde2e-logs' | ||
| - name: USE_EXISTING_CLUSTER | ||
| value: 'TRUE' |
There was a problem hiding this comment.
This currently skips for a non-sts cluster and provisions new one, but if we ever have a reserve for that type of cluster it would be useful.
But since this yaml is not boilerplated, we can remove this.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #437 +/- ##
=======================================
Coverage 41.57% 41.57%
=======================================
Files 27 27
Lines 2665 2665
=======================================
Hits 1108 1108
Misses 1478 1478
Partials 79 79 🚀 New features to boost your workflow:
|
CIO does not use cluster reserve due to non-STS type cluster. Include full healthcheck template separate from boilerplated template to allow this to be used from saas test job.
|
@ritmun: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Updated description. It's the |
Gotcha, so it's a flag that existed in the only template but now is being removed. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joshbranham, ritmun The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
CIO does not use cluster reserve due to non-STS type cluster. Include full healthcheck template separate from boilerplated template to remove
--only-health-check-nodesarg and and allow this to be used from saas test job.