Skip to content

SDCICD-1772 add template for full healthcheck#437

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
ritmun:SDCICD-1772
Mar 3, 2026
Merged

SDCICD-1772 add template for full healthcheck#437
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
ritmun:SDCICD-1772

Conversation

@ritmun
Copy link
Contributor

@ritmun ritmun commented Mar 3, 2026

CIO does not use cluster reserve due to non-STS type cluster. Include full healthcheck template separate from boilerplated template to remove --only-health-check-nodes arg and and allow this to be used from saas test job.

@openshift-ci openshift-ci bot requested review from reedcort and sam-nguyen7 March 3, 2026 00:23
Copy link
Contributor

@joshbranham joshbranham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which piece in here tells it to use a full cluster health check?

- name: LOG_BUCKET
value: 'osde2e-logs'
- name: USE_EXISTING_CLUSTER
value: 'TRUE'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This currently skips for a non-sts cluster and provisions new one, but if we ever have a reserve for that type of cluster it would be useful.

But since this yaml is not boilerplated, we can remove this.

@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.57%. Comparing base (28f0dba) to head (adb6ef8).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #437   +/-   ##
=======================================
  Coverage   41.57%   41.57%           
=======================================
  Files          27       27           
  Lines        2665     2665           
=======================================
  Hits         1108     1108           
  Misses       1478     1478           
  Partials       79       79           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

CIO does not use cluster reserve due to non-STS type cluster. Include full healthcheck template separate from boilerplated template to allow this to be used from saas test job.
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2026

@ritmun: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ritmun
Copy link
Contributor Author

ritmun commented Mar 3, 2026

Which piece in here tells it to use a full cluster health check?

Updated description. It's the --only-health-check-nodes arg piece. That checks health of nodes only.

@joshbranham
Copy link
Contributor

Which piece in here tells it to use a full cluster health check?

Updated description. It's the --only-health-check-nodes arg piece. That checks health of nodes only.

Gotcha, so it's a flag that existed in the only template but now is being removed.

@joshbranham
Copy link
Contributor

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joshbranham, ritmun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit c441b0a into openshift:master Mar 3, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants