NO-ISSUE: Support Using a Custom OpenShift Installer#82
NO-ISSUE: Support Using a Custom OpenShift Installer#82pawanpinjarkar wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
@pawanpinjarkar: This pull request explicitly references no jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pawanpinjarkar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pawanpinjarkar: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| if [[ -n "${CUSTOM_OPENSHIFT_INSTALLER_PATH}" ]]; then | ||
| echo "Using custom openshift installer from ${CUSTOM_OPENSHIFT_INSTALLER_PATH}" | ||
| patch_openshift_install_release_version "${full_ocp_version}" | ||
| $SUDO podman run --rm -it --privileged --pull always --net=host -v "${appliance_work_dir}"/:/assets:Z --env OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE="${RELEASE_IMAGE_URL}" "${pull_spec}" build live-iso --log-level debug --debug-base-ignition |
There was a problem hiding this comment.
Hi @pawanpinjarkar, do you know why it was necessary to add --env OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE="${RELEASE_IMAGE_URL}"?
There was a problem hiding this comment.
I believe it was needed when using --debug-base-ignition 6897de0#r2007907256
cc @andfasano
| This will produce the openshift-install binary in the bin/ directory. | ||
|
|
||
| 2. Set the Installer Path and Run the Script | ||
| Set the CUSTOM_OPENSHIFT_INSTALLER_PATH environment variable to the directory containing your custom-built openshift-install binary, then run the build script: |
There was a problem hiding this comment.
Instead of an environment variable could this be a command line flag?
There was a problem hiding this comment.
We did not add it like a CLI option because we wanted to keep it only for dev/test purpose. It is meant to be used rarely. @andfasano thoughts?
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Useful for dev/test debugging.