HYPERFLEET-29 | feat: Add YAML table format for adapter requirements #41

yasun1 · 2026-01-26T04:03:56Z

Summary by CodeRabbit

New Features
- Added a structured adapters configuration for specifying cluster and nodepool adapter requirements, replacing the previous inline environment-variable approach.
Documentation
- Updated deployment docs with three configuration options: structured Helm values, Helm-based env var override, and direct CLI/env usage; includes defaults and examples for adapter configuration.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2026-01-26T04:04:37Z

Walkthrough

This PR moves adapter configuration from directly setting environment variables to a structured Helm values block and updates the deployment template and docs accordingly. It adds an adapters section in values.yaml (with cluster and nodepool lists), conditionally emits HYPERFLEET_CLUSTER_ADAPTERS and HYPERFLEET_NODEPOOL_ADAPTERS (JSON-serialized and quoted) in the deployment template when those lists are present, and revises documentation to describe three configuration options (values YAML, Helm env overrides, or direct env vars).

Sequence Diagram(s)

sequenceDiagram
    participant Dev as Developer (values.yaml / Helm CLI)
    participant Helm as Helm Template Engine
    participant K8s as Kubernetes API/Deployment
    participant Pod as Container Runtime (app)

    Dev->>Helm: Provide values.yaml (adapters.cluster/adapters.nodepool) or env overrides
    Helm->>K8s: Render deployment.yaml (conditionally include HYPERFLEET_* env vars) and apply
    K8s->>Pod: Schedule Pod with rendered env vars
    Pod->>Pod: Application reads HYPERFLEET_CLUSTER_ADAPTERS / HYPERFLEET_NODEPOOL_ADAPTERS env

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

HYPERFLEET-29 | feat(config): add configurable adapter requirements #40 — Implements the complementary API-side changes that read and process the adapter requirements environment variables set by these Helm template changes.

Suggested labels

lgtm, approved

Suggested reviewers

aredenba-rh

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: refactoring adapter requirements from inline environment variables to a YAML table format. It's specific, concise, and clearly summarizes the primary objective of the changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 2

🤖 Fix all issues with AI agents

In `@charts/templates/deployment.yaml`:
- Around line 77-85: The template currently skips adapter env vars when users
set empty lists because Helm treats empty slices as false; update the
conditional checks in charts/templates/deployment.yaml to test for key existence
and nil explicitly (e.g., use hasKey .Values.adapterRequirements "cluster" and
.Values.adapterRequirements.cluster != nil, and similarly for "nodepool") so an
explicit [] value is rendered as HYPERFLEET_*_ADAPTERS: "[]"; also ensure
values.yaml can default these keys to null (not undefined) so users can set []
to clear defaults and the template will emit the empty list JSON via the
existing toJson | quote pipeline.

In `@docs/deployment.md`:
- Around line 96-120: The markdown uses bold lines as section titles for the
three options, triggering MD036; replace those bolded option lines with proper
Markdown headings (e.g., "### Option 1: Using structured values (Helm only,
recommended)", "### Option 2: Using environment variables in Helm", "### Option
3: Direct environment variable (non-Helm)") so the document structure is
semantic and lint-friendly; update the surrounding blocks (code fences and
descriptions) to remain under each new heading and ensure heading level matches
the surrounding document hierarchy.

coderabbitai · 2026-01-26T04:09:46Z

charts/templates/deployment.yaml

+        {{- if .Values.adapterRequirements }}
+        {{- if .Values.adapterRequirements.cluster }}
+        - name: HYPERFLEET_CLUSTER_ADAPTERS
+          value: {{ .Values.adapterRequirements.cluster | toJson | quote }}
+        {{- end }}
+        {{- if .Values.adapterRequirements.nodepool }}
+        - name: HYPERFLEET_NODEPOOL_ADAPTERS
+          value: {{ .Values.adapterRequirements.nodepool | toJson | quote }}
+        {{- end }}


⚠️ Potential issue | 🟡 Minor

Allow explicit empty adapter lists (currently impossible).
With if .Values.adapterRequirements.cluster, an empty list evaluates false, so users cannot explicitly set [] to clear defaults. Consider checking for nil and defaulting to null in values.yaml so empty lists can be emitted as [].

🛠️ Suggested change (template)

- {{- if .Values.adapterRequirements.cluster }} + {{- if ne .Values.adapterRequirements.cluster nil }} - name: HYPERFLEET_CLUSTER_ADAPTERS value: {{ .Values.adapterRequirements.cluster | toJson | quote }} {{- end }} - {{- if .Values.adapterRequirements.nodepool }} + {{- if ne .Values.adapterRequirements.nodepool nil }} - name: HYPERFLEET_NODEPOOL_ADAPTERS value: {{ .Values.adapterRequirements.nodepool | toJson | quote }} {{- end }}

🛠️ Suggested change (values.yaml defaults)

adapterRequirements: # Required adapters for cluster "Ready" state # Default: ["validation", "dns", "pullsecret", "hypershift"] - cluster: [] + cluster: null # Required adapters for nodepool "Ready" state # Default: ["validation", "hypershift"] - nodepool: [] + nodepool: null

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

{{- if .Values.adapterRequirements }}

{{- if .Values.adapterRequirements.cluster }}

- name: HYPERFLEET_CLUSTER_ADAPTERS

value: {{ .Values.adapterRequirements.cluster | toJson | quote }}

{{- end }}

{{- if .Values.adapterRequirements.nodepool }}

- name: HYPERFLEET_NODEPOOL_ADAPTERS

value: {{ .Values.adapterRequirements.nodepool | toJson | quote }}

{{- end }}

{{- if .Values.adapterRequirements }}

{{- if ne .Values.adapterRequirements.cluster nil }}

- name: HYPERFLEET_CLUSTER_ADAPTERS

value: {{ .Values.adapterRequirements.cluster | toJson | quote }}

{{- end }}

{{- if ne .Values.adapterRequirements.nodepool nil }}

- name: HYPERFLEET_NODEPOOL_ADAPTERS

value: {{ .Values.adapterRequirements.nodepool | toJson | quote }}

{{- end }}

🤖 Prompt for AI Agents

In `@charts/templates/deployment.yaml` around lines 77 - 85, The template currently skips adapter env vars when users set empty lists because Helm treats empty slices as false; update the conditional checks in charts/templates/deployment.yaml to test for key existence and nil explicitly (e.g., use hasKey .Values.adapterRequirements "cluster" and .Values.adapterRequirements.cluster != nil, and similarly for "nodepool") so an explicit [] value is rendered as HYPERFLEET_*_ADAPTERS: "[]"; also ensure values.yaml can default these keys to null (not undefined) so users can set [] to clear defaults and the template will emit the empty list JSON via the existing toJson | quote pipeline.

coderabbitai · 2026-01-26T04:09:46Z

docs/deployment.md

+**Option 1: Using structured values (Helm only, recommended)**
+```yaml
+# values.yaml
+adapterRequirements:
+  cluster:
+    - validation
+    - dns
+    - pullsecret
+    - hypershift
+  nodepool:
+    - validation
+    - hypershift
+```
+
+**Option 2: Using environment variables in Helm**
+```yaml
+# values.yaml
+env:
+  - name: HYPERFLEET_CLUSTER_ADAPTERS
+    value: '["validation","dns","pullsecret","hypershift"]'
+  - name: HYPERFLEET_NODEPOOL_ADAPTERS
+    value: '["validation","hypershift"]'
+```
+
+**Option 3: Direct environment variable (non-Helm)**


⚠️ Potential issue | 🟡 Minor

Use headings instead of bold lines for options (MD036).
markdownlint flags emphasis-as-heading here; headings improve structure and fix lint.

✏️ Proposed fix

-**Option 1: Using structured values (Helm only, recommended)** +#### Option 1: Using structured values (Helm only, recommended) -**Option 2: Using environment variables in Helm** +#### Option 2: Using environment variables in Helm -**Option 3: Direct environment variable (non-Helm)** +#### Option 3: Direct environment variable (non-Helm)

🧰 Tools

🪛 markdownlint-cli2 (0.18.1)

96-96: Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

110-110: Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

120-120: Emphasis used instead of a heading

(MD036, no-emphasis-as-heading)

🤖 Prompt for AI Agents

In `@docs/deployment.md` around lines 96 - 120, The markdown uses bold lines as section titles for the three options, triggering MD036; replace those bolded option lines with proper Markdown headings (e.g., "### Option 1: Using structured values (Helm only, recommended)", "### Option 2: Using environment variables in Helm", "### Option 3: Direct environment variable (non-Helm)") so the document structure is semantic and lint-friendly; update the surrounding blocks (code fences and descriptions) to remain under each new heading and ensure heading level matches the surrounding document hierarchy.

86254860 · 2026-01-26T05:56:41Z

docs/deployment.md

+    - hypershift
+```
+
+**Option 2: Using environment variables in Helm**


Do you mean it also support Option 2 and 3?

Yes, also support Option 2 and 3

update

86254860 · 2026-01-27T03:16:11Z

/lgtm

openshift-ci · 2026-01-27T03:16:17Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 86254860

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [86254860]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot requested review from 86254860 and AlexVulaj January 26, 2026 04:04

coderabbitai bot reviewed Jan 26, 2026

View reviewed changes

86254860 reviewed Jan 26, 2026

View reviewed changes

HYPERFLEET-29 | feat: Add YAML table format for adapter requirements

c362f63

update

yasun1 force-pushed the HYPERFLEET-29 branch from ea592f6 to c362f63 Compare January 26, 2026 07:38

openshift-ci bot assigned 86254860 Jan 27, 2026

openshift-ci bot added the lgtm label Jan 27, 2026

openshift-ci bot added the approved label Jan 27, 2026

openshift-merge-bot bot merged commit a529611 into openshift-hyperfleet:main Jan 27, 2026
8 checks passed

coderabbitai bot mentioned this pull request Feb 4, 2026

HYPERFLEET-606 - feat: Make adapter configuration mandatory #46

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HYPERFLEET-29 | feat: Add YAML table format for adapter requirements #41

HYPERFLEET-29 | feat: Add YAML table format for adapter requirements #41

Uh oh!

yasun1 commented Jan 26, 2026 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jan 26, 2026 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot Jan 26, 2026

Uh oh!

coderabbitai bot Jan 26, 2026

Uh oh!

86254860 Jan 26, 2026

Uh oh!

yasun1 Jan 26, 2026

Uh oh!

86254860 commented Jan 27, 2026

Uh oh!

openshift-ci bot commented Jan 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

HYPERFLEET-29 | feat: Add YAML table format for adapter requirements #41

HYPERFLEET-29 | feat: Add YAML table format for adapter requirements #41

Uh oh!

Conversation

yasun1 commented Jan 26, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Sequence Diagram(s)

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

86254860 Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

yasun1 Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

86254860 commented Jan 27, 2026

Uh oh!

openshift-ci bot commented Jan 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

yasun1 commented Jan 26, 2026 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 26, 2026 •

edited

Loading