HYPERFLEET-363 | refactor(config): standardize environment variables with HYPERFLEET_ prefix#38
HYPERFLEET-363 | refactor(config): standardize environment variables with HYPERFLEET_ prefix#38yasun1 wants to merge 1 commit intoopenshift-hyperfleet:mainfrom
Conversation
… output format update update update
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
WalkthroughThis pull request standardizes environment variable naming conventions by prefixing LOG-related variables (LOG_LEVEL, LOG_FORMAT, LOG_OUTPUT), masking variables (MASKING_ENABLED, MASKING_HEADERS, MASKING_FIELDS), and database debug variables (DB_DEBUG) with a HYPERFLEET_ prefix. Additionally, the default logging format is changed from JSON to text. Changes span configuration files, tests, and documentation to maintain consistency. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
pkg/config/db.go (1)
138-140: Update stale comment to reference new environment variable names.The comment references the old
DB_DEBUGandLOG_LEVELnames instead ofHYPERFLEET_DB_DEBUGandHYPERFLEET_LOG_LEVEL.Suggested fix
-// GetGormLogLevel returns the appropriate GORM log level based on DB_DEBUG and LOG_LEVEL. -// DB_DEBUG=true always returns Info level, otherwise follows LOG_LEVEL mapping. +// GetGormLogLevel returns the appropriate GORM log level based on HYPERFLEET_DB_DEBUG and HYPERFLEET_LOG_LEVEL. +// HYPERFLEET_DB_DEBUG=true always returns Info level, otherwise follows HYPERFLEET_LOG_LEVEL mapping.docs/logging.md (1)
428-434: Stale environment variable reference in Data Masking section.Line 430 still references
MASKING_ENABLED=trueinstead of the newHYPERFLEET_MASKING_ENABLED=true.Suggested fix
-Sensitive data is automatically masked when `MASKING_ENABLED=true`: +Sensitive data is automatically masked when `HYPERFLEET_MASKING_ENABLED=true`:
Summary by CodeRabbit
Documentation
Chores
✏️ Tip: You can customize this high-level summary in your review settings.