Skip to content

Add configuration options for supporting Kubernetes usage#8

Merged
MartinaeyNL merged 3 commits intomainfrom
add-config-options
Apr 22, 2025
Merged

Add configuration options for supporting Kubernetes usage#8
MartinaeyNL merged 3 commits intomainfrom
add-config-options

Conversation

@wborn
Copy link
Member

@wborn wborn commented Mar 14, 2025

Adds configuration options so the container can be used in Kubernetes:

  • HTTP_PORT, HTTPS_PORT: Allows for reconfiguring the ports as containers are not allowed to bind to privileged ports (< 1024)
  • NAMESERVER: In Kubernetes the cluster DNS service needs to be used (typically 10.96.0.10:53)

TODO:

  • Fix X-Forwarded-Port header when reconfiguring the HTTP, HTTPS ports
  • Update README.md

@wborn wborn changed the title Add configuration options Add configuration options for use in Kubernetes Mar 20, 2025
@wborn wborn changed the title Add configuration options for use in Kubernetes Add configuration options for Kubernetes usage Mar 20, 2025
@wborn wborn changed the title Add configuration options for Kubernetes usage Add configuration options for supporting Kubernetes usage Mar 20, 2025
@wborn wborn force-pushed the add-config-options branch from b4fd34d to 912973c Compare April 14, 2025 13:05
@wborn wborn marked this pull request as ready for review April 14, 2025 13:31
@wborn wborn requested review from ebariaux and richturner April 14, 2025 13:31
@wborn wborn added the Enhancement Improvement of an existing feature label Apr 14, 2025
@ebariaux
Copy link

I've been using this branch (minus 2 last commits) on EKS for a while now, without any issue.
Did visual review only of last commits and seems OK to me (see one comment on doc).

@wborn wborn requested a review from MartinaeyNL April 22, 2025 07:40
@MartinaeyNL MartinaeyNL merged commit 294a5a2 into main Apr 22, 2025
@MartinaeyNL MartinaeyNL deleted the add-config-options branch April 22, 2025 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Improvement of an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants