Skip to content

feat: include key version details in get key response#131

Merged
doanhluongsap merged 2 commits into
mainfrom
task/get-key-return-version
Mar 12, 2026
Merged

feat: include key version details in get key response#131
doanhluongsap merged 2 commits into
mainfrom
task/get-key-return-version

Conversation

@doanhluongsap

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

- Add latest_key_version_id and latest_rotation_time to the KeyResponse

Special notes for your reviewer:


Release note:


@github-actions

github-actions Bot commented Mar 11, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 12, 2026, 9:33 AM

@hyperspace-insights

Copy link
Copy Markdown
Contributor

Summary

The following content is AI-generated and provides a summary of the pull request:


Add Latest Key Version Details to GetKeyResponse

New Feature

✨ Extended the GetKeyResponse protobuf message to include two new fields: latest_key_version_id and latest_rotation_time. These fields provide consumers of the GetKey API with the ID of the most recent key version and the timestamp of the last key rotation (in RFC3339 format), without requiring an additional request.

Changes

  • proto/plugin/keystore/operations/v1/operations.proto: Added two new fields to the GetKeyResponse message:

    • latest_key_version_id (field 5): The ID of the latest key version.
    • latest_rotation_time (field 6): The timestamp of the latest key rotation in RFC3339 format.
  • proto/plugin/keystore/operations/v1/operations.pb.go: Regenerated Go protobuf bindings reflecting the new fields, including updated struct definition, raw descriptor bytes, and two new getter methods — GetLatestKeyVersionId() and GetLatestRotationTime().

  • proto/plugin/keystore/operations/v1/operations.pb.validate.go: Updated generated validation code to acknowledge the two new fields (no validation rules applied).


  • 🔄 Regenerate and Update Summary
  • ✏️ Insert as PR Description (deletes this comment)
  • 🗑️ Delete comment
PR Bot Information

Version: 1.18 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback

  • Event Trigger: pull_request.opened
  • Correlation ID: 49bf3220-1d67-11f1-9ffa-6d33e05ee53e
  • LLM: anthropic--claude-4.6-sonnet
  • Output Template: Default Template
  • Summary Prompt: Default Prompt

💌 Have ideas or want to contribute? Create an issue and share your thoughts with us!
📑 Check out the documentation for more information.
📬 Subscribe to the Hyperspace PR Bot DL to get the latest announcements and pilot features!

Made with ❤️ by Hyperspace.

@hyperspace-insights hyperspace-insights Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR adds two new fields (latest_key_version_id and latest_rotation_time) to the GetKeyResponse message. The changes are consistent across the .proto source, the generated .pb.go file, and the generated validation file. The main concern is the use of a raw string for latest_rotation_time instead of google.protobuf.Timestamp, which provides no type safety or structured validation for the documented RFC3339 format.

PR Bot Information

Version: 1.18 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback

  • Event Trigger: pull_request.opened
  • Correlation ID: 49bf3220-1d67-11f1-9ffa-6d33e05ee53e
  • LLM: anthropic--claude-4.6-sonnet

Comment thread proto/plugin/keystore/operations/v1/operations.proto Outdated
@doanhluongsap doanhluongsap force-pushed the task/get-key-return-version branch 2 times, most recently from e4e892b to 266cc95 Compare March 11, 2026 16:51
@doanhluongsap doanhluongsap force-pushed the task/get-key-return-version branch from 266cc95 to 7e14b22 Compare March 12, 2026 09:02
@doanhluongsap doanhluongsap merged commit 041b15a into main Mar 12, 2026
9 checks passed
@doanhluongsap doanhluongsap deleted the task/get-key-return-version branch March 12, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants