Skip to content

fix: change back the workflow pemissions to contents: write #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nnicora merged 1 commit into from
Mar 5, 2026
Merged

fix: change back the workflow pemissions to contents: write #126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.triggered.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
workflow_dispatch:

permissions:
contents: write
contents: read

@hyperspace-insights hyperspace-insights Bot Mar 5, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic Error: Change contradicts the stated intent of the PR

The PR title says "fix: change back the workflow permissions to contents: write", but this diff does the opposite — it downgrades contents from write to read.

A release workflow almost certainly needs contents: write to create tags, GitHub Releases, or push commits. With only contents: read, any step that writes to the repository (e.g., creating a release or tag) will fail with a permissions error.

Should revert to contents: write to match the stated fix and satisfy the workflow's runtime requirements.

Suggested change
contents: read
contents: write

Double-check suggestion before committing. Edit this comment for amendments.

Please provide feedback on the review comment by checking the appropriate box:

  • 🌟 Awesome comment, a human might have missed that.
  • ✅ Helpful comment
  • 🤷 Neutral
  • ❌ This comment is not helpful

pull-requests: write

jobs:
Expand Down
Loading