pandoc: point to a joint OCI org image#1078
Closed
vbatts wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Vincent Batts <vbatts@hashbangbash.com>
Contributor
|
LGTM. Thanks @vbatts For the record, before this PR, Travis tests was sometimes failing with: |
tianon
reviewed
Dec 7, 2020
| DOCKER ?= $(shell command -v docker 2>/dev/null) | ||
| PANDOC ?= $(shell command -v pandoc 2>/dev/null) | ||
|
|
||
| PANDOC_CONTAINER ?= quay.io/oci/pandoc:1.17.0.3-2.fc25.x86_64 |
Member
There was a problem hiding this comment.
Suggested change
| PANDOC_CONTAINER ?= quay.io/oci/pandoc:1.17.0.3-2.fc25.x86_64 | |
| PANDOC_IMAGE ?= quay.io/oci/pandoc:1.17.0.3-2.fc25.x86_64 |
😇
Given this version string is now much more complex than trusting vbatts/pandoc:latest, would it also make sense to either have a docker pull $(PANDOC_IMAGE) target or perhaps have install.tools do that?
Member
There was a problem hiding this comment.
(To avoid the .travis.yml duplication, which will inevitably get out of sync or trip folks up if they need to bump this for whatever reason)
Member
There was a problem hiding this comment.
quay.io/oci/pandoc:latest seems to work fine. Is there any reason for using an older version?
Closed
Contributor
|
Can we modify to use the image located at https://github.com/opencontainers/container-images? |
Member
Author
|
stale PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vincent Batts vbatts@hashbangbash.com