refactor(tray): remove two unused tray menu helpers (~240 lines) - #251
Merged
shanselman merged 2 commits intoMay 1, 2026
Merged
Conversation
23 tasks
Method was never called. Active tray menu is driven by BuildTrayMenuPopup(TrayMenuWindow) via ShowTrayMenuPopup(). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Method was explicitly marked "for reference" in a comment but never called. BuildTrayMenuPopup(TrayMenuWindow) is the active implementation. Removes the comment and the entire method body. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
|
Thanks @AlexAlves87! This dead-code cleanup looks good. I rebased the PR onto current master and kept the tray-menu helper removals, while dropping the unrelated internal .gitignore entries so the upstream diff stays focused. |
shanselman
force-pushed
the
refactor/remove-dead-tray-menu
branch
from
May 1, 2026 17:07
2ec2db7 to
f3ceeda
Compare
Contributor
Author
|
@shanselman — thanks again for cleaning up the diff here. I found the same Sorry again for the extra noise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes two legacy tray-menu helpers from
App.xaml.csthat no longer appear to participate in the active tray menu flow.The current tray menu path goes through
ShowTrayMenuPopup()/BuildTrayMenuPopup(TrayMenuWindow)/TrayMenuWindow, not the olderMenuFlyout-based helpers.Changes
BuildTrayMenuFlyout()BuildTrayMenu(MenuFlyout)Testing
./build.ps1dotnet test ./tests/OpenClaw.Shared.Tests/OpenClaw.Shared.Tests.csproj --no-restoredotnet test ./tests/OpenClaw.Tray.Tests/OpenClaw.Tray.Tests.csproj --no-restoreNotes
BuildTrayMenuFlyout()removal is the straightforward dead-code cleanup.BuildTrayMenu(MenuFlyout)path also looks unused, but it had an explicit "kept for reference" comment in the file.