Filled positions cannot hire#209
Merged
mlespiau merged 4 commits intoopencats:masterfrom Mar 29, 2017
Merged
Conversation
…tatus 'Placed') or if it can still 'place' candidates
…else, total number of available openings is increased by 1
RussH
approved these changes
Jan 24, 2017
Member
RussH
left a comment
There was a problem hiding this comment.
I agree the functional improvement. Will need Matias to review code...
Contributor
|
The design could be improved - this feature is adding if-cases in at least two places of the code when we could use polymorphism instead for a cleaner design. I'll approve as I believe we can fix these design issues once symfony becomes the new standard. |
mlespiau
approved these changes
Mar 29, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To allow to add candidate only into job orders that are allowed to accept candidates.