Conversation
pakrym-oai
approved these changes
Apr 7, 2025
onmete
added a commit
to onmete/lightspeed-service
that referenced
this pull request
Feb 13, 2026
MCP tools that accept no arguments (e.g. configuration_contexts_list
from openshift-mcp-server) produce an inputSchema of {"type": "object"}
without a "properties" key. This is valid per JSON Schema and the MCP
spec, but causes two failures:
1. LangChain's BaseTool.args does json_schema["properties"] → KeyError
2. OpenAI API rejects the function with "object schema missing properties"
Normalize tool schemas after loading from MCP servers by injecting an
empty "properties": {} when the key is missing. This matches the fix
applied in openai/openai-agents-python#454 for the same issue.
Co-authored-by: Cursor <cursoragent@cursor.com>
5 tasks
onmete
added a commit
to onmete/lightspeed-service
that referenced
this pull request
Feb 26, 2026
MCP tools that accept no arguments (e.g. configuration_contexts_list
from openshift-mcp-server) produce an inputSchema of {"type": "object"}
without a "properties" key. This is valid per JSON Schema and the MCP
spec, but causes two failures:
1. LangChain's BaseTool.args does json_schema["properties"] → KeyError
2. OpenAI API rejects the function with "object schema missing properties"
Normalize tool schemas after loading from MCP servers by injecting an
empty "properties": {} when the key is missing. This matches the fix
applied in openai/openai-agents-python#454 for the same issue.
Co-authored-by: Cursor <cursoragent@cursor.com>
onmete
added a commit
to onmete/lightspeed-service
that referenced
this pull request
Feb 26, 2026
MCP tools that accept no arguments (e.g. configuration_contexts_list
from openshift-mcp-server) produce an inputSchema of {"type": "object"}
without a "properties" key. This is valid per JSON Schema and the MCP
spec, but causes two failures:
1. LangChain's BaseTool.args does json_schema["properties"] → KeyError
2. OpenAI API rejects the function with "object schema missing properties"
Normalize tool schemas after loading from MCP servers by injecting an
empty "properties": {} when the key is missing. This matches the fix
applied in openai/openai-agents-python#454 for the same issue.
Co-authored-by: Cursor <cursoragent@cursor.com>
Made-with: Cursor
onmete
added a commit
to onmete/lightspeed-service
that referenced
this pull request
Feb 26, 2026
MCP tools that accept no arguments (e.g. configuration_contexts_list
from openshift-mcp-server) produce an inputSchema of {"type": "object"}
without a "properties" key. This is valid per JSON Schema and the MCP
spec, but causes two failures:
1. LangChain's BaseTool.args does json_schema["properties"] → KeyError
2. OpenAI API rejects the function with "object schema missing properties"
Normalize tool schemas after loading from MCP servers by injecting an
empty "properties": {} when the key is missing. This matches the fix
applied in openai/openai-agents-python#454 for the same issue.
Co-authored-by: Cursor <cursoragent@cursor.com>
Made-with: Cursor
sriroopar
pushed a commit
to sriroopar/lightspeed-service
that referenced
this pull request
Mar 2, 2026
MCP tools that accept no arguments (e.g. configuration_contexts_list
from openshift-mcp-server) produce an inputSchema of {"type": "object"}
without a "properties" key. This is valid per JSON Schema and the MCP
spec, but causes two failures:
1. LangChain's BaseTool.args does json_schema["properties"] → KeyError
2. OpenAI API rejects the function with "object schema missing properties"
Normalize tool schemas after loading from MCP servers by injecting an
empty "properties": {} when the key is missing. This matches the fix
applied in openai/openai-agents-python#454 for the same issue.
Co-authored-by: Cursor <cursoragent@cursor.com>
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #449 - TLDR, OpenAI's API expects the properties field to be present, whereas the MCP schema explicitly allows omitting the properties field. MCP Spec