Add managed policy for in-app updates - #35537
Conversation
## What changed - Add the stable, default-enabled `in_app_updates` requirements-only feature. - Allow administrators to disable in-app updates through `[features]` in `requirements.toml`. - Expose the policy through `configRequirements/read` and include it in the config schema. ## Testing - Verify that in-app updates are enabled by default and disabled by the managed requirement. - Verify that `configRequirements/read` returns the configured policy. GitOrigin-RevId: e9c7074b516fe58385fdf7dc8420c0109c0c3df6
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
dd464e9 to
95637f7
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd464e91cd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| .loader_overrides(LoaderOverrides::without_managed_config_for_tests()) | ||
| .build() | ||
| .await?; | ||
| assert!(default_config.features.enabled(Feature::InAppUpdates)); |
There was a problem hiding this comment.
This assertion only restates the default_enabled: true value declared in the feature registry, so it will fail whenever that static default is intentionally changed without validating additional behavior. Retain the managed-requirement assertion below, which exercises the actual configuration logic, but remove this prohibited test of a statically defined value.
AGENTS.md reference: AGENTS.md:L29-L31
Useful? React with 👍 / 👎.
Add managed policy for in-app updates
What changed
in_app_updatesrequirements-only feature.[features]inrequirements.toml.configRequirements/readand include it in the config schema.Testing
configRequirements/readreturns the configured policy.