Trace remote exec-server connection setup - #35275
Conversation
## What changed - Preserve the current tracing span and subscriber when lazy remote environment startup runs in a background task. - Add spans for the remote connection, environment registry, Noise, and rendezvous WebSocket stages, including relevant environment and registration identifiers. - Propagate the current trace context to environment registry connection and harness-key validation requests. GitOrigin-RevId: 0044c3eb94d59c6a6b92752d3d372195be4adb81
9a22d04 to
c3e926e
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9a22d043dd
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| } | ||
| } | ||
| }))) | ||
| .in_current_span() |
There was a problem hiding this comment.
When start_connecting runs inside a caller span, .in_current_span() instruments the entire detached startup future, retaining that caller span while deferred readiness or connection setup waits and giving the connection work an inaccurate lifetime and parentage. connect_once is already instrumented in this change, so preserve subscriber propagation if needed but remove this redundant call-site span attachment, as required by the repository tracing convention.
AGENTS.md reference: AGENTS.md:L45-L48
Useful? React with 👍 / 👎.
Trace remote exec-server connection setup
What changed
startup runs in a background task.
rendezvous WebSocket stages, including relevant environment and registration
identifiers.
harness-key validation requests.