Skip to content

Use current MCP authority for elicitation reviews - #35205

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/826a157aa70fc8e3a9e3a14ecb0261bf7b63f63a
Jul 24, 2026
Merged

Use current MCP authority for elicitation reviews#35205
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/826a157aa70fc8e3a9e3a14ecb0261bf7b63f63a

Conversation

@copyberry

@copyberry copyberry Bot commented Jul 24, 2026

Copy link
Copy Markdown

Use current MCP authority for elicitation reviews

Why

MCP elicitation reviewers are reused across runtime refreshes, while an active
turn can retain the approval settings it started with. Reviewing against that
turn could therefore apply stale authority after session settings changed.

What changed

  • Read the latest published MCP runtime configuration when reviewing an
    elicitation, including the approval policy, permission profile, configuration
    layers, and reviewer selection.
  • Apply never and granular MCP-elicitation policy decisions before routing an
    eligible request to Guardian.
  • Keep MCP runtime startup registered for refresh invalidation through session
    creation.

Testing

Added coverage that refreshes a running session and verifies the same reviewer
uses the latest authority for Guardian routing, denial, and empty-form
auto-approval.

## Why

MCP elicitation reviewers are reused across runtime refreshes, while an active
turn can retain the approval settings it started with. Reviewing against that
turn could therefore apply stale authority after session settings changed.

## What changed

- Read the latest published MCP runtime configuration when reviewing an
  elicitation, including the approval policy, permission profile, configuration
  layers, and reviewer selection.
- Apply `never` and granular MCP-elicitation policy decisions before routing an
  eligible request to Guardian.
- Keep MCP runtime startup registered for refresh invalidation through session
  creation.

## Testing

Added coverage that refreshes a running session and verifies the same reviewer
uses the latest authority for Guardian routing, denial, and empty-form
auto-approval.

GitOrigin-RevId: 826a157aa70fc8e3a9e3a14ecb0261bf7b63f63a
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/826a157aa70fc8e3a9e3a14ecb0261bf7b63f63a branch from 6ef58e9 to 000d254 Compare July 24, 2026 15:17
@copyberry
copyberry Bot merged commit 000d254 into main Jul 24, 2026
14 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/826a157aa70fc8e3a9e3a14ecb0261bf7b63f63a branch July 24, 2026 15:18
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants