Skip to content

Make the Apps recovery exposure test deterministic - #35196

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/deb21d4b41f353c3f84428616769af9faa1a0487
Jul 24, 2026
Merged

Make the Apps recovery exposure test deterministic#35196
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/deb21d4b41f353c3f84428616769af9faa1a0487

Conversation

@copyberry

@copyberry copyberry Bot commented Jul 24, 2026

Copy link
Copy Markdown

Make the Apps recovery exposure test deterministic

Why

The Apps MCP background retry could complete before the test inspected the
initial sampling request, making the recovery timing nondeterministic.

What changed

  • Add a test-server gate that can hold and explicitly release the next
    successful Apps MCP initialization.
  • Use a dedicated MCP mock server so the held initialization does not block
    model responses or app discovery.
  • Assert that recovery uses exactly two initialization attempts and that Apps
    guidance and the deferred namespace appear only after the gate is released.

## Why

The Apps MCP background retry could complete before the test inspected the
initial sampling request, making the recovery timing nondeterministic.

## What changed

- Add a test-server gate that can hold and explicitly release the next
  successful Apps MCP initialization.
- Use a dedicated MCP mock server so the held initialization does not block
  model responses or app discovery.
- Assert that recovery uses exactly two initialization attempts and that Apps
  guidance and the deferred namespace appear only after the gate is released.

GitOrigin-RevId: deb21d4b41f353c3f84428616769af9faa1a0487
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/deb21d4b41f353c3f84428616769af9faa1a0487 branch from 414c0c3 to 5f6a2c3 Compare July 24, 2026 14:42
@copyberry
copyberry Bot merged commit 5f6a2c3 into main Jul 24, 2026
14 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/deb21d4b41f353c3f84428616769af9faa1a0487 branch July 24, 2026 14:43
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 24, 2026
@DRM66
DRM66 temporarily deployed to issue-triage July 24, 2026 14:45 — with GitHub Actions Inactive
@DRM66
DRM66 temporarily deployed to issue-triage July 24, 2026 14:45 — with GitHub Actions Inactive
@DRM66
DRM66 temporarily deployed to issue-triage July 24, 2026 14:45 — with GitHub Actions Inactive
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants