Preserve output from hooks that exit before reading stdin - #35194
Merged
copyberry[bot] merged 1 commit intoJul 24, 2026
Conversation
## Why A hook can exit successfully without consuming its JSON input. If it closes stdin while Codex is still writing, the resulting broken pipe should not hide the hook's exit status and output. ## What changed Ignore broken-pipe errors when writing hook stdin and continue waiting for the process result. Other stdin write errors remain failures. ## Testing Add a cross-platform regression test that sends a large input to a fast-exiting hook and verifies that its successful status and stdout are preserved. GitOrigin-RevId: e1b6e7c6ac5e39232e49b45245ea0df9d34d1fe6
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/e1b6e7c6ac5e39232e49b45245ea0df9d34d1fe6
branch
from
July 24, 2026 14:37
d50e008 to
634a998
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/e1b6e7c6ac5e39232e49b45245ea0df9d34d1fe6
branch
July 24, 2026 14:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve output from hooks that exit before reading stdin
Why
A hook can exit successfully without consuming its JSON input. If it closes
stdin while Codex is still writing, the resulting broken pipe should not hide
the hook's exit status and output.
What changed
Ignore broken-pipe errors when writing hook stdin and continue waiting for the
process result. Other stdin write errors remain failures.
Testing
Add a cross-platform regression test that sends a large input to a
fast-exiting hook and verifies that its successful status and stdout are
preserved.