Route extension warnings to app-server threads - #35168
Merged
copyberry[bot] merged 1 commit intoJul 24, 2026
Merged
Conversation
## Why Extension warnings need a stable thread target even when they are emitted outside an active turn. ## What changed - Add `ExtensionWarning` and a dedicated `ExtensionEventSink::emit_warning` path with an explicit thread ID and optional turn ID. - Deliver extension warnings as thread-scoped app-server `warning` notifications, preserving listener ordering and waiting briefly for a subscriber when no listener is active. - Move skills warnings to the new path, limiting provider catalog warnings to four messages of 256 bytes each. ## Testing - Cover warning routing, ordering, UTF-8-safe truncation, subscriber fallback, and invalid thread IDs. - Verify skills warning bounds and app-server delivery of executor catalog budget warnings. GitOrigin-RevId: 4dcb1ba7f17c0edb1a9d548f9568e0c734bffc15
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/4dcb1ba7f17c0edb1a9d548f9568e0c734bffc15
branch
from
July 24, 2026 12:29
e1ec676 to
5dd992a
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/4dcb1ba7f17c0edb1a9d548f9568e0c734bffc15
branch
July 24, 2026 12:30
constantins2001
temporarily deployed
to
issue-triage
July 24, 2026 12:58 — with 
GitHub Actions
Inactive
constantins2001
temporarily deployed
to
issue-triage
July 24, 2026 12:58 — with
GitHub Actions
Inactive
constantins2001
temporarily deployed
to
issue-triage
July 24, 2026 12:58 — with
GitHub Actions
Inactive
constantins2001
temporarily deployed
to
issue-triage
July 24, 2026 12:59 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Route extension warnings to app-server threads
Why
Extension warnings need a stable thread target even when they are emitted outside an active turn.
What changed
ExtensionWarningand a dedicatedExtensionEventSink::emit_warningpath with an explicit thread ID and optional turn ID.warningnotifications, preserving listener ordering and waiting briefly for a subscriber when no listener is active.Testing