Skip to content

Preserve Windows sandbox proxy settings in guardian sessions - #35036

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/214655c6e6d97360906431773dc0de0fdda2db6e
Jul 23, 2026
Merged

Preserve Windows sandbox proxy settings in guardian sessions#35036
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/214655c6e6d97360906431773dc0de0fdda2db6e

Conversation

@copyberry

@copyberry copyberry Bot commented Jul 23, 2026

Copy link
Copy Markdown

Preserve Windows sandbox proxy settings in guardian sessions

Why

Guardian review commands can run without the proxy-port environment used to
configure the parent session. Reconciling persistent Windows sandbox settings
for those commands can discard the parent's proxy configuration.

What changed

  • Add a session-level Windows sandbox proxy-settings mode and use Preserve
    for guardian review sessions while keeping Reconcile as the default.
  • Carry the mode through unified exec and the exec-server sandbox context to
    Windows process launches.
  • In preserve mode, reuse the proxy settings recorded by the existing sandbox
    setup marker.

Testing

Added coverage for guardian session configuration, exec-server transport, and
preserving an existing setup marker when proxy-port environment variables are
absent.

## Why

Guardian review commands can run without the proxy-port environment used to
configure the parent session. Reconciling persistent Windows sandbox settings
for those commands can discard the parent's proxy configuration.

## What changed

- Add a session-level Windows sandbox proxy-settings mode and use `Preserve`
  for guardian review sessions while keeping `Reconcile` as the default.
- Carry the mode through unified exec and the exec-server sandbox context to
  Windows process launches.
- In preserve mode, reuse the proxy settings recorded by the existing sandbox
  setup marker.

## Testing

Added coverage for guardian session configuration, exec-server transport, and
preserving an existing setup marker when proxy-port environment variables are
absent.

GitOrigin-RevId: 214655c6e6d97360906431773dc0de0fdda2db6e
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/214655c6e6d97360906431773dc0de0fdda2db6e branch from 24c2ad3 to b115de9 Compare July 23, 2026 23:36
@copyberry
copyberry Bot merged commit b115de9 into main Jul 23, 2026
31 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/214655c6e6d97360906431773dc0de0fdda2db6e branch July 23, 2026 23:37
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants