Adapt keyboard event reporting to the terminal - #35021
Merged
copyberry[bot] merged 1 commit intoJul 23, 2026
Merged
Conversation
## Why Reporting key event types can leak an exit-shortcut release into the parent shell in iTerm2 and can cause tmux's `xterm` extended-key format to lose Shift+Enter. ## What changed - Select keyboard enhancement flags using the detected terminal and tmux extended-key format. - Disable event-type reporting for iTerm2 and tmux's `xterm` format while retaining alternate-key reporting. - Preserve event-type reporting for other terminals and tmux's `csi-u` format so repeat events remain distinguishable. ## Testing Added unit coverage for iTerm2, Kitty, unknown terminals, and both tmux extended-key formats. GitOrigin-RevId: 03a6b9d5443f626da5279413a14933af2a0ec3e5
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/03a6b9d5443f626da5279413a14933af2a0ec3e5
branch
from
July 23, 2026 22:35
417dd85 to
fe0d472
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/03a6b9d5443f626da5279413a14933af2a0ec3e5
branch
July 23, 2026 22:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt keyboard event reporting to the terminal
Why
Reporting key event types can leak an exit-shortcut release into the parent
shell in iTerm2 and can cause tmux's
xtermextended-key format to loseShift+Enter.
What changed
extended-key format.
xtermformat whileretaining alternate-key reporting.
csi-uformat so repeat events remain distinguishable.
Testing
Added unit coverage for iTerm2, Kitty, unknown terminals, and both tmux
extended-key formats.