Separate Codex error details from retry metadata - #34996
Merged
copyberry[bot] merged 1 commit intoJul 23, 2026
Merged
Conversation
## What changed - Wrap `CodexErrorDetails` and an optional retry delay in `CodexErr`, allowing any mapped error to preserve server-provided retry timing. - Generate the payload-free `CodexErrKind` classification alongside the error details and reuse it for analytics. - Update error handling sites to inspect `CodexErr::details()` while preserving existing display, debug, protocol mapping, and retryability behavior. ## Testing - Add coverage for legacy debug formatting, error-specific retryability, and retry-delay propagation through API error mapping. GitOrigin-RevId: d3ab8a305f2a2ee21d0c0a8c8c388b06dda9c59a
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/d3ab8a305f2a2ee21d0c0a8c8c388b06dda9c59a
branch
from
July 23, 2026 19:32
5a332ec to
7bafdad
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/d3ab8a305f2a2ee21d0c0a8c8c388b06dda9c59a
branch
July 23, 2026 19:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separate Codex error details from retry metadata
What changed
CodexErrorDetailsand an optional retry delay inCodexErr, allowing any mapped error to preserve server-provided retry timing.CodexErrKindclassification alongside the error details and reuse it for analytics.CodexErr::details()while preserving existing display, debug, protocol mapping, and retryability behavior.Testing