Skip to content

Initialize execution environments with the final HTTP policy - #34995

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/928fa31e6b4bcfbe1a121cade2f351427fdfa0f4
Jul 23, 2026
Merged

Initialize execution environments with the final HTTP policy#34995
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/928fa31e6b4bcfbe1a121cade2f351427fdfa0f4

Conversation

@copyberry

@copyberry copyberry Bot commented Jul 23, 2026

Copy link
Copy Markdown

Initialize execution environments with the final HTTP policy

Why

The TUI must inspect the default execution environment before loading its final
configuration. Initializing the environment manager at that point can give
startup services the bootstrap HTTP policy instead of the effective policy after
managed requirements are applied.

What changed

  • Split environment discovery from manager construction so callers can inspect
    the default environment without starting remote connections.
  • Build the environment manager after final configuration loading and pass its
    resolved HttpClientFactory through all construction paths.
  • Add shared test support for managers that use the legacy default HTTP policy.

Testing

  • Cover connection-free environment discovery and explicit HTTP policy
    propagation.
  • Verify TUI startup services use the final managed respect_system_proxy value.

## Why

The TUI must inspect the default execution environment before loading its final
configuration. Initializing the environment manager at that point can give
startup services the bootstrap HTTP policy instead of the effective policy after
managed requirements are applied.

## What changed

- Split environment discovery from manager construction so callers can inspect
  the default environment without starting remote connections.
- Build the environment manager after final configuration loading and pass its
  resolved `HttpClientFactory` through all construction paths.
- Add shared test support for managers that use the legacy default HTTP policy.

## Testing

- Cover connection-free environment discovery and explicit HTTP policy
  propagation.
- Verify TUI startup services use the final managed `respect_system_proxy` value.

GitOrigin-RevId: 928fa31e6b4bcfbe1a121cade2f351427fdfa0f4
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/928fa31e6b4bcfbe1a121cade2f351427fdfa0f4 branch from 00065a6 to 265cd2e Compare July 23, 2026 19:25
@copyberry
copyberry Bot merged commit 265cd2e into main Jul 23, 2026
30 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/928fa31e6b4bcfbe1a121cade2f351427fdfa0f4 branch July 23, 2026 19:27
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant