Skip to content

Honor the configured SQLite home across state consumers - #34994

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/1de1cdd1d6ff1d70bbb6c360c8352e6543fb8ebf
Jul 23, 2026
Merged

Honor the configured SQLite home across state consumers#34994
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/1de1cdd1d6ff1d70bbb6c360c8352e6543fb8ebf

Conversation

@copyberry

@copyberry copyberry Bot commented Jul 23, 2026

Copy link
Copy Markdown

Honor the configured SQLite home across state consumers

Why

Codex and SQLite data can use separate home directories, but state consumers
could reconstruct database paths from the Codex home instead of consistently
using the resolved SQLite configuration.

What changed

  • Pass SqliteConfig through the core, rollout, state runtime, and thread store
    instead of passing a directory and rebuilding the configuration downstream.
  • Use that shared configuration for state, logs, memories, goals, and paginated
    thread-history database access, including integrity checks and cleanup.
  • Reject state database handles whose SQLite configuration does not match the
    requesting store.

Testing

Add coverage with separate Codex and SQLite homes that verifies startup
backfill, thread listing, and paginated history all use the configured SQLite
directory.

## Why

Codex and SQLite data can use separate home directories, but state consumers
could reconstruct database paths from the Codex home instead of consistently
using the resolved SQLite configuration.

## What changed

- Pass `SqliteConfig` through the core, rollout, state runtime, and thread store
  instead of passing a directory and rebuilding the configuration downstream.
- Use that shared configuration for state, logs, memories, goals, and paginated
  thread-history database access, including integrity checks and cleanup.
- Reject state database handles whose SQLite configuration does not match the
  requesting store.

## Testing

Add coverage with separate Codex and SQLite homes that verifies startup
backfill, thread listing, and paginated history all use the configured SQLite
directory.

GitOrigin-RevId: 1de1cdd1d6ff1d70bbb6c360c8352e6543fb8ebf
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/1de1cdd1d6ff1d70bbb6c360c8352e6543fb8ebf branch from aee938b to c769a05 Compare July 23, 2026 19:19
@copyberry
copyberry Bot merged commit c769a05 into main Jul 23, 2026
30 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/1de1cdd1d6ff1d70bbb6c360c8352e6543fb8ebf branch July 23, 2026 19:20
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant