Move MCP connection helpers into the test module - #34962
Merged
copyberry[bot] merged 1 commit intoJul 23, 2026
Merged
Conversation
Keep the `McpConnectionSet` test constructors and accessors alongside the connection manager tests instead of defining test-only helpers in the production module. GitOrigin-RevId: 925392f8b7d903b131ef1b49afd7e50f41226b1f
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/925392f8b7d903b131ef1b49afd7e50f41226b1f
branch
from
July 23, 2026 15:40
9267155 to
9e1f43d
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/925392f8b7d903b131ef1b49afd7e50f41226b1f
branch
July 23, 2026 15:42
JavierPiedra
temporarily deployed
to
issue-triage
July 23, 2026 15:55 — with 
GitHub Actions
Inactive
JavierPiedra
temporarily deployed
to
issue-triage
July 23, 2026 15:55 — with
GitHub Actions
Inactive
JavierPiedra
temporarily deployed
to
issue-triage
July 23, 2026 15:55 — with
GitHub Actions
Inactive
jojoaurelien
temporarily deployed
to
issue-triage
July 23, 2026 16:16 — with
GitHub Actions
Inactive
jojoaurelien
temporarily deployed
to
issue-triage
July 23, 2026 16:16 — with
GitHub Actions
Inactive
jojoaurelien
temporarily deployed
to
issue-triage
July 23, 2026 16:16 — with
GitHub Actions
Inactive
michellzappa
temporarily deployed
to
issue-triage
July 23, 2026 16:18 — with
GitHub Actions
Inactive
michellzappa
temporarily deployed
to
issue-triage
July 23, 2026 16:18 — with
GitHub Actions
Inactive
michellzappa
temporarily deployed
to
issue-triage
July 23, 2026 16:18 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move MCP connection helpers into the test module
Keep the
McpConnectionSettest constructors and accessors alongside theconnection manager tests instead of defining test-only helpers in the
production module.