Consolidate thread startup around StartThreadOptions - #34814
Merged
copyberry[bot] merged 1 commit intoJul 22, 2026
Merged
Conversation
## What changed - Add `StartThreadOptions::new` to provide the standard configuration for a new thread. - Make `ThreadManager::start_thread` the single thread-start entry point and migrate callers from the previous convenience methods. - Derive default environment selections when `environments` is `None`, while preserving explicit selections, including an empty list. GitOrigin-RevId: 8977dc11aed54c5e1215a81eaed2b2cf5fc6087a
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/8977dc11aed54c5e1215a81eaed2b2cf5fc6087a
branch
from
July 22, 2026 19:33
7a04506 to
08ae0fc
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/8977dc11aed54c5e1215a81eaed2b2cf5fc6087a
branch
July 22, 2026 19:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate thread startup around
StartThreadOptionsWhat changed
StartThreadOptions::newto provide the standard configuration for a new thread.ThreadManager::start_threadthe single thread-start entry point and migrate callers from the previous convenience methods.environmentsisNone, while preserving explicit selections, including an empty list.