Skip to content

Order unified exec lifecycle events reliably - #34713

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/46a118552bb1a4658b78aa5a5ca76eb8c5fba571
Jul 22, 2026
Merged

Order unified exec lifecycle events reliably#34713
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/46a118552bb1a4658b78aa5a5ca76eb8c5fba571

Conversation

@copyberry

@copyberry copyberry Bot commented Jul 22, 2026

Copy link
Copy Markdown

Order unified exec lifecycle events reliably

What changed

  • Treat output-task closure as the signal that trailing output is complete, drain any remaining chunks before publishing command completion, and retain the grace period as a fallback.
  • Wait for deferred network-denial classification before emitting the final command result.
  • Serialize write_stdin interaction and completion events so an interaction that exits a process is published first, and avoid pruning processes while their terminal events are being finalized.

Testing

  • Add coverage for late output, missing output-close signals, late network denials, interaction/completion ordering, cross-platform aggregated output, and pruning during finalization.

## What changed

- Treat output-task closure as the signal that trailing output is complete, drain any remaining chunks before publishing command completion, and retain the grace period as a fallback.
- Wait for deferred network-denial classification before emitting the final command result.
- Serialize `write_stdin` interaction and completion events so an interaction that exits a process is published first, and avoid pruning processes while their terminal events are being finalized.

## Testing

- Add coverage for late output, missing output-close signals, late network denials, interaction/completion ordering, cross-platform aggregated output, and pruning during finalization.

GitOrigin-RevId: 46a118552bb1a4658b78aa5a5ca76eb8c5fba571
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/46a118552bb1a4658b78aa5a5ca76eb8c5fba571 branch from 49b65e8 to 9fc715c Compare July 22, 2026 09:29
@copyberry
copyberry Bot merged commit 9fc715c into main Jul 22, 2026
31 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/46a118552bb1a4658b78aa5a5ca76eb8c5fba571 branch July 22, 2026 09:30
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 22, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.