Require absolute paths for test SQLite configuration - #34411
Merged
copyberry[bot] merged 1 commit intoJul 20, 2026
Merged
Conversation
## Why `SqliteConfig` stores its home as an `AbsolutePathBuf`, but its test constructor previously accepted a `PathBuf` and checked the absolute-path invariant at runtime. ## What changed - Make `SqliteConfig::new_for_testing` accept an `AbsolutePathBuf` directly, removing its fallible conversion and `expect`. - Update SQLite test setup to convert temporary directory paths with `PathExt::abs` at each call site. GitOrigin-RevId: 93585b9aea805e2449b3465ac20eeb39417ed555
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/93585b9aea805e2449b3465ac20eeb39417ed555
branch
from
July 20, 2026 20:55
7c89141 to
81e89fa
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/93585b9aea805e2449b3465ac20eeb39417ed555
branch
July 20, 2026 20:56
AbdullahSaad5
temporarily deployed
to
issue-triage
July 20, 2026 20:57 — with 
GitHub Actions
Inactive
AbdullahSaad5
temporarily deployed
to
issue-triage
July 20, 2026 20:57 — with
GitHub Actions
Inactive
AbdullahSaad5
temporarily deployed
to
issue-triage
July 20, 2026 20:57 — with
GitHub Actions
Inactive
AbdullahSaad5
temporarily deployed
to
issue-triage
July 20, 2026 20:58 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require absolute paths for test SQLite configuration
Why
SqliteConfigstores its home as anAbsolutePathBuf, but its test constructorpreviously accepted a
PathBufand checked the absolute-path invariant atruntime.
What changed
SqliteConfig::new_for_testingaccept anAbsolutePathBufdirectly,removing its fallible conversion and
expect.PathExt::absat each call site.