Propagate approval rejection reasons - #34400
Merged
copyberry[bot] merged 1 commit intoJul 20, 2026
Merged
Conversation
## What changed - Change `ReviewDecision::Denied` to carry a rejection string and update the generated protocol schemas. - Preserve specific rejection reasons through command, patch, network, MCP, delegated, and automatic approval flows so tool results can return them to the model. - Distinguish invalid approval responses from user declines and truncate oversized rejection messages before adding them to model context. ## Testing - Add coverage for denial serialization, invalid app-server approval responses, dropped automatic reviews, network rejection propagation, and rejection-message truncation. GitOrigin-RevId: d48a55643aa03c7ecfa08a8e4b669913eec5464a
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/d48a55643aa03c7ecfa08a8e4b669913eec5464a
branch
from
July 20, 2026 19:24
c91a2d0 to
e52c35b
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/d48a55643aa03c7ecfa08a8e4b669913eec5464a
branch
July 20, 2026 19:25
NoahLinckeScout
temporarily deployed
to
issue-triage
July 20, 2026 19:32 — with 
GitHub Actions
Inactive
NoahLinckeScout
temporarily deployed
to
issue-triage
July 20, 2026 19:32 — with
GitHub Actions
Inactive
NoahLinckeScout
temporarily deployed
to
issue-triage
July 20, 2026 19:32 — with
GitHub Actions
Inactive
NoahLinckeScout
temporarily deployed
to
issue-triage
July 20, 2026 19:33 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate approval rejection reasons
What changed
ReviewDecision::Deniedto carry a rejection string and update the generated protocol schemas.Testing