Run compact session-start hooks before turn continuation - #34396
Merged
copyberry[bot] merged 1 commit intoJul 20, 2026
Merged
Conversation
## Why Mid-turn auto-compaction queued `SessionStart` hooks but continued sampling before running them. This delayed hook-provided context and ignored requests to stop the continuation. ## What changed Drain pending session-start hooks immediately after successful mid-turn auto-compaction. End the turn when a hook requests a stop; otherwise include its additional context in the next sampling request. ## Testing Added coverage for repeated compactions in one turn, context delivery without leaking hooks into the next user turn, and stop requests that block sampling. GitOrigin-RevId: c57708a792fb47d98d95c38d7d91bcd9f235be84
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/c57708a792fb47d98d95c38d7d91bcd9f235be84
branch
from
July 20, 2026 19:10
3e260e4 to
8c41ed3
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/c57708a792fb47d98d95c38d7d91bcd9f235be84
branch
July 20, 2026 19:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run compact session-start hooks before turn continuation
Why
Mid-turn auto-compaction queued
SessionStarthooks but continued samplingbefore running them. This delayed hook-provided context and ignored requests to
stop the continuation.
What changed
Drain pending session-start hooks immediately after successful mid-turn
auto-compaction. End the turn when a hook requests a stop; otherwise include
its additional context in the next sampling request.
Testing
Added coverage for repeated compactions in one turn, context delivery without
leaking hooks into the next user turn, and stop requests that block sampling.