Ignore inherited ACEs when refreshing Windows write roots - #34392
Merged
copyberry[bot] merged 1 commit intoJul 20, 2026
Conversation
## Why An inherited `FILE_DELETE_CHILD` grant can make a write root look stale, but `SET_ACCESS` cannot replace an ACE inherited from an ancestor. Treating that grant as explicit causes unnecessary ACL refresh attempts that cannot converge. ## What changed - Add explicit-ACE filtering to the Windows DACL permission checks. - Refresh a write root only when `FILE_DELETE_CHILD` is present in an explicit allow ACE, while retaining effective-permission checks for required rights. - Ignore inherited stale rights when deciding whether `SET_ACCESS` must repair an allow ACE. ## Testing Add a Windows regression test covering a write root that inherits `FILE_DELETE_CHILD`, verifying that repeated refresh checks leave its explicit write ACE unchanged. GitOrigin-RevId: d0df9429efcf299da3ff3c1bce92942684803293
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/d0df9429efcf299da3ff3c1bce92942684803293
branch
from
July 20, 2026 18:29
ed3a4b5 to
bd92b05
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/d0df9429efcf299da3ff3c1bce92942684803293
branch
July 20, 2026 18:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ignore inherited ACEs when refreshing Windows write roots
Why
An inherited
FILE_DELETE_CHILDgrant can make a write root look stale, butSET_ACCESScannot replace an ACE inherited from an ancestor. Treating thatgrant as explicit causes unnecessary ACL refresh attempts that cannot converge.
What changed
FILE_DELETE_CHILDis present in an explicitallow ACE, while retaining effective-permission checks for required rights.
SET_ACCESSmust repairan allow ACE.
Testing
Add a Windows regression test covering a write root that inherits
FILE_DELETE_CHILD, verifying that repeated refresh checks leave its explicitwrite ACE unchanged.