Enable memories for paginated threads - #34386
Merged
copyberry[bot] merged 1 commit intoJul 20, 2026
Merged
Conversation
## Why Paginated threads keep metadata updates in SQLite, while their rollout retains the initial `memory_mode`. Reconciliation could therefore overwrite the current setting with a stale value, and memory processing excluded these threads entirely. ## What changed - Include paginated threads in stage 1 memory job selection and global memory output lookup. - Preserve the SQLite `memory_mode` when reconciling or backfilling an existing paginated thread, while continuing to seed missing rows and restore legacy threads from rollouts. - Omit `memory_mode` alongside Git metadata when flushing resumed paginated history. ## Testing Added coverage for preserving disabled memory mode during reconciliation and backfill, selecting eligible paginated threads, and omitting initial metadata on paginated resume. GitOrigin-RevId: 2a6e16068e69680728757fbec27aeefae45b8110
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/2a6e16068e69680728757fbec27aeefae45b8110
branch
from
July 20, 2026 17:42
3dc88fd to
2793c82
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/2a6e16068e69680728757fbec27aeefae45b8110
branch
July 20, 2026 17:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable memories for paginated threads
Why
Paginated threads keep metadata updates in SQLite, while their rollout retains the initial
memory_mode. Reconciliation could therefore overwrite the current setting with a stale value, and memory processing excluded these threads entirely.What changed
memory_modewhen reconciling or backfilling an existing paginated thread, while continuing to seed missing rows and restore legacy threads from rollouts.memory_modealongside Git metadata when flushing resumed paginated history.Testing
Added coverage for preserving disabled memory mode during reconciliation and backfill, selecting eligible paginated threads, and omitting initial metadata on paginated resume.