Avoid cloning Responses WebSocket payloads - #34381
Merged
copyberry[bot] merged 1 commit intoJul 20, 2026
Merged
Conversation
## Why Building a Responses WebSocket request copied the model, instructions, input history, tools, and other request settings into a second payload before serialization. ## What changed - Make `ResponseCreateWsRequest` borrow shared fields from `ResponsesApiRequest`. - Keep only WebSocket-specific fields owned, and allocate a separate input vector only for incremental continuations. - Restore response item IDs after preparing a full request so the request retained for continuation matching keeps its original state. ## Testing Update the serialization test to verify that the borrowed WebSocket request produces the same wire payload as the Responses API request plus its WebSocket-specific fields. GitOrigin-RevId: b63d746b7f5164b5204ab95b057c914a4aeb71e1
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/b63d746b7f5164b5204ab95b057c914a4aeb71e1
branch
from
July 20, 2026 17:19
832bd94 to
6b9a559
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/b63d746b7f5164b5204ab95b057c914a4aeb71e1
branch
July 20, 2026 17:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid cloning Responses WebSocket payloads
Why
Building a Responses WebSocket request copied the model, instructions, input
history, tools, and other request settings into a second payload before
serialization.
What changed
ResponseCreateWsRequestborrow shared fields fromResponsesApiRequest.vector only for incremental continuations.
retained for continuation matching keeps its original state.
Testing
Update the serialization test to verify that the borrowed WebSocket request
produces the same wire payload as the Responses API request plus its
WebSocket-specific fields.