Avoid cloning hyperlink text during TUI rendering - #34366
Merged
copyberry[bot] merged 1 commit intoJul 20, 2026
Merged
Conversation
## What changed Add a borrowed `Line` conversion and use it when rendering and measuring hyperlink-aware history and pager content. This preserves line styling and alignment while avoiding clones of the underlying span strings. GitOrigin-RevId: c9cd6ff5ec63cd29719ea2ae51acede7364f2bd8
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/c9cd6ff5ec63cd29719ea2ae51acede7364f2bd8
branch
from
July 20, 2026 15:40
07ae316 to
28aacbb
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/c9cd6ff5ec63cd29719ea2ae51acede7364f2bd8
branch
July 20, 2026 15:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid cloning hyperlink text during TUI rendering
What changed
Add a borrowed
Lineconversion and use it when rendering and measuringhyperlink-aware history and pager content. This preserves line styling and
alignment while avoiding clones of the underlying span strings.