Avoid cloning deferred TUI lifecycle payloads - #34347
Merged
copyberry[bot] merged 1 commit intoJul 20, 2026
Merged
Conversation
## What changed - Move lifecycle and approval payloads into either the interrupt queue or the immediate handler instead of cloning them for both branches. - Borrow MCP elicitation request metadata while constructing the corresponding form, and consume apply-patch changes after collecting notification paths. ## Testing - Add a history replay test confirming deferred MCP start and completion events remain FIFO after streaming finishes. GitOrigin-RevId: 84ed34f6ff173463a1da016dc140405392c0ba45
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/84ed34f6ff173463a1da016dc140405392c0ba45
branch
from
July 20, 2026 13:55
aece773 to
ada5a79
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/84ed34f6ff173463a1da016dc140405392c0ba45
branch
July 20, 2026 13:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid cloning deferred TUI lifecycle payloads
What changed
immediate handler instead of cloning them for both branches.
form, and consume apply-patch changes after collecting notification paths.
Testing
remain FIFO after streaming finishes.