Reject unsupported history modes when loading rollouts - #34344
Merged
copyberry[bot] merged 1 commit intoJul 20, 2026
Merged
Conversation
## Why The first session metadata record defines a rollout's history mode. If that record uses an unsupported mode, skipping it as a parse error can cause later metadata copied from fork history to be treated as canonical. ## What changed - Validate session metadata history modes before deserializing rollout lines, while continuing to tolerate unknown modes in copied fork history. - Simplify thread status registration to pass only the thread ID instead of a fully materialized `Thread`. GitOrigin-RevId: 9de4313d4a76b279d32bb49b2016a4f5d07507c1
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/9de4313d4a76b279d32bb49b2016a4f5d07507c1
branch
from
July 20, 2026 13:40
3b84854 to
86102db
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/9de4313d4a76b279d32bb49b2016a4f5d07507c1
branch
July 20, 2026 13:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reject unsupported history modes when loading rollouts
Why
The first session metadata record defines a rollout's history mode. If that
record uses an unsupported mode, skipping it as a parse error can cause later
metadata copied from fork history to be treated as canonical.
What changed
while continuing to tolerate unknown modes in copied fork history.
fully materialized
Thread.