Skip to content

Avoid liveness races when starting side conversations - #34199

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/1f9fb0586db8094bf5a2624bc4e1de06c9a783a1
Jul 19, 2026
Merged

Avoid liveness races when starting side conversations#34199
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/1f9fb0586db8094bf5a2624bc4e1de06c9a783a1

Conversation

@copyberry

@copyberry copyberry Bot commented Jul 19, 2026

Copy link
Copy Markdown

Avoid liveness races when starting side conversations

Why

The thread/started notification for a newly forked side conversation can arrive after the fork response. Selecting the side thread in that window could incorrectly report that it was unavailable.

What changed

  • Seed agent navigation from the side-fork response before selecting the new thread.
  • Skip redundant liveness and parent-title reads for side threads that already have local state, while preserving liveness checks for uncached agent threads.

Testing

  • Cover side-thread selection before thread/started is delivered.
  • Verify uncached threads are still checked and regular forks still resolve their parent title.

## Why

The `thread/started` notification for a newly forked side conversation can arrive after the fork response. Selecting the side thread in that window could incorrectly report that it was unavailable.

## What changed

- Seed agent navigation from the side-fork response before selecting the new thread.
- Skip redundant liveness and parent-title reads for side threads that already have local state, while preserving liveness checks for uncached agent threads.

## Testing

- Cover side-thread selection before `thread/started` is delivered.
- Verify uncached threads are still checked and regular forks still resolve their parent title.

GitOrigin-RevId: 1f9fb0586db8094bf5a2624bc4e1de06c9a783a1
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/1f9fb0586db8094bf5a2624bc4e1de06c9a783a1 branch from fb041e1 to 4d7a5c7 Compare July 19, 2026 17:00
@copyberry
copyberry Bot merged commit 4d7a5c7 into main Jul 19, 2026
32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/1f9fb0586db8094bf5a2624bc4e1de06c9a783a1 branch July 19, 2026 17:01
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants