Skip to content

Avoid resending the model for reasoning shortcuts #34047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copyberry merged 1 commit into from
Jul 18, 2026
+8 −12
Merged

Avoid resending the model for reasoning shortcuts #34047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion codex-rs/tui/src/chatwidget/reasoning_shortcuts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,8 @@ impl ChatWidget {
)));
}
} else {
self.apply_model_and_effort_without_persist(current_model, Some(next_effort));
self.app_event_tx
.send(AppEvent::UpdateReasoningEffort(Some(next_effort)));
}

true
Expand Down
17 changes: 6 additions & 11 deletions codex-rs/tui/src/chatwidget/tests/popups_and_settings.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3387,7 +3387,6 @@ async fn model_reasoning_selection_popup_extra_high_warning_snapshot() {
async fn assert_reasoning_shortcuts_update_effort(
key_events: [KeyEvent; 2],
expected_effort: ReasoningEffortConfig,
expect_model_update: bool,
) {
for key_event in key_events {
let (mut chat, mut rx, _op_rx) = make_chatwidget_manual(Some("gpt-5.4")).await;
Expand All @@ -3397,14 +3396,12 @@ async fn assert_reasoning_shortcuts_update_effort(
chat.handle_key_event(key_event);

let events = std::iter::from_fn(|| rx.try_recv().ok()).collect::<Vec<_>>();
if expect_model_update {
assert!(
events.iter().any(
|event| matches!(event, AppEvent::UpdateModel(model) if model == "gpt-5.4")
),
"expected model update event for {key_event:?}; events: {events:?}"
);
}
assert!(
events
.iter()
.all(|event| !matches!(event, AppEvent::UpdateModel(_))),
"did not expect model update event for {key_event:?}; events: {events:?}"
);
assert!(
events.iter().any(|event| matches!(
event,
Expand All @@ -3429,7 +3426,6 @@ async fn reasoning_up_shortcuts_raise_reasoning_effort() {
KeyEvent::new(KeyCode::Up, KeyModifiers::SHIFT),
],
ReasoningEffortConfig::High,
/*expect_model_update*/ true,
)
.await;
}
Expand All @@ -3442,7 +3438,6 @@ async fn reasoning_down_shortcuts_lower_reasoning_effort() {
KeyEvent::new(KeyCode::Down, KeyModifiers::SHIFT),
],
ReasoningEffortConfig::Low,
/*expect_model_update*/ false,
)
.await;
}
Expand Down
Loading