Fix quoted hook commands on Windows - #33926
Merged
copyberry[bot] merged 1 commit intoJul 17, 2026
Merged
Conversation
## Why Windows hook commands whose executable paths contain spaces fail when their outer quotes are escaped during argument construction. ## What changed - Pass hook command strings as raw arguments to the default Windows shell. - Do the same for configured shells that use the case-insensitive `/c` flag, while retaining normal argument handling for other shells. ## Testing Add a Windows regression test that runs a quoted `.cmd` hook from a directory with spaces through both the default shell and an explicit `COMSPEC /c` shell. GitOrigin-RevId: 0e7ce44203e01d3823daaaec750c2aeadfcd34b7
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/0e7ce44203e01d3823daaaec750c2aeadfcd34b7
branch
from
July 17, 2026 23:25
fc80533 to
3ac476b
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/0e7ce44203e01d3823daaaec750c2aeadfcd34b7
branch
July 17, 2026 23:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix quoted hook commands on Windows
Why
Windows hook commands whose executable paths contain spaces fail when their
outer quotes are escaped during argument construction.
What changed
/cflag,while retaining normal argument handling for other shells.
Testing
Add a Windows regression test that runs a quoted
.cmdhook from a directorywith spaces through both the default shell and an explicit
COMSPEC /cshell.